Great module - thank you!

Requesting that on the Node Ownership Settings page, under Email Settings that for each email there is an option (checkbox?) like "Do not send these emails".

I actually only need for the first one, Admin email. With thousands of nodes being claimed on my site, I would like to cut down on all of these emails coming back to me that I don't need.

Even though I would only want to "turn it off" for one of the 3 emails, it makes sense to give this option to not send the emails for each of the 3 emails types, since others might want to disable all of the emails.

Thank you!

CommentFileSizeAuthor
#6 interdiff-23650807-4-6.txt3.96 KBvinay15
#6 2365807-6.patch4.47 KBvinay15
#4 disable_emails_on_settingform-23650807-#3.patch4.65 KBPradnya Pingat
#3 disable_emails_on_settingform-23650807-#2.patch4.67 KBPradnya Pingat

Comments

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented

Acknowledged, we will add this in our plan.

Pradnya Pingat’s picture

Pradnya Pingat commented
Assigned: Unassigned » Pradnya Pingat
Pradnya Pingat’s picture

Pradnya Pingat commented
Status: Active » Needs review
StatusFileSize
new disable_emails_on_settingform-23650807-#2.patch4.67 KB

Adding checkbox for all three email options to disable mails .

Pradnya Pingat’s picture

Pradnya Pingat commented
StatusFileSize
new disable_emails_on_settingform-23650807-#3.patch4.65 KB

Adding checkbox for all three email options to disable mails .updating coding standard issues.

swarad07’s picture

swarad07
Primary language English
Location Navi Mumbai, India
commented
Status: Needs review » Needs work 
+++ b/nodeownership.module
@@ -157,8 +157,16 @@ function nodeownership_claim_insert() {
+  ¶
...
+    $mail = drupal_mail('nodeownership', 'user_claim', $recipient['mail'], $language);
+    drupal_set_message(t('Your claim has been recorded and an email has been sent to the site administrators.'));
...
+  else {
+    drupal_set_message(t('Your claim has been recorded.'));   ¶
+  }

Remove Empty spaces. There are many in your patch.

vinay15’s picture

vinay15
he/him
Primary language Marathi
Location Navi Mumbai
commented
Assigned: Pradnya Pingat » vinay15
Status: Needs work » Needs review
StatusFileSize
new 2365807-6.patch4.47 KB
new interdiff-23650807-4-6.txt3.96 KB

Fixed whitespace issues as suggested in #5.