Search specific tags are not available and hook_query_TAG_alter hooks are not invoked (forward-port the tests)

Given this has tests and is easy enough => RTBC

Did we check there is no similar bug in 8.0.x?

Yeah, let's confirm if there is an equivalent Drupal 8 bug first and move the issue there first if so, then backport...

All the code in Drupal 8 looks very similar, so my best guess would be that the bug does exist there too, but I didn't test it.

RTBC (based on tests still passing), thanks! The backport looks even better!

Testbot fluke.

Looks like a testbot fluke.

Committed to 7.x - thanks!

Fixed a few small issues with the code comment on commit:

--- a/modules/search/search.extender.inc
+++ b/modules/search/search.extender.inc
@@ -151,13 +151,13 @@ class SearchQuery extends SelectQueryExtender {
 
     // Add a search_* tag. This needs to be added before any preExecute methods
     // for decorated queries are called, as $this->prepared will be set to TRUE
-    // and tag will added in execute will never get used. For example, if $query
-    // is extended by 'SearchQuery' then 'PagerDefault'. The search specific
-    // tag will be added too late (when preExecute() has already been called
-    // from the PagerDefault extender), and as a consequence will not be
-    // available to hook_query_alter() implementations. Nor will the correct
-    // hook_query_TAG_alter() implementations get invoked.
-    // @ see node_search_execute()
+    // and tags added in the execute method will never get used. For example,
+    // if $query is extended by 'SearchQuery' then 'PagerDefault', the
+    // search-specific tag will be added too late (when preExecute() has
+    // already been called from the PagerDefault extender), and as a
+    // consequence will not be available to hook_query_alter() implementations,
+    // nor will the correct hook_query_TAG_alter() implementations get invoked.
+    // See node_search_execute().
     $this->addTag('search_' . $module);
 
     return $this;

Actually, should these tests (and maybe the code comments that were added here) be forward-ported to Drupal 8?

It seems that Drupal 8 has some tests for the search query altering (see the testQueryAlter() method) but not as comprehensive as the ones here.

This patch is not working properly. Try this:

  if ($query->hasTag('search_user')) {
    krumo('search_user');
  }

This goes back to #2116391: Tag user_search_execute() query for realname and other modules and #2117881: How extend query conditions via hook_query_alter()?. I hoped you fixed it here, but no - it is still broken.

Also, your example is really bad, with no context.

What do you mean? Have you seen the lonk to my full example?

The code looks like a generic patch, but is not. It implements inconsistent behaviour and this is bad as every core search should have the same type of tag. User search is missing the tag for sure and I really need this for realname module.

There is a patch in my linked issue. Can you RTBC it, please?

This looks like it was already done in 8.0.x #1366020: Overhaul SearchQuery; make search redirects use GET query params for keywords

Commit: 4e8713299993549a0841095dfb4ed8aebb72f903

   public function searchExpression($expression, $type) {
     $this->searchExpression = $expression;
     $this->type = $type;
 
+    // Add query tag.
+    $this->addTag('search_' . $type);
+
+    // Initialize conditions and status.
+    $this->conditions = db_and();
+    $this->status = 0;
+
     return $this;
   }

@kim: #2116391: Tag user_search_execute() query for realname and other modules is not in D8

This is actually a duplicate of #1435834: Cannot alter search queries, tag added too late, which was where this was fixed in 8.x and the backport has not happend yet.