Follow-up to #2172235: Upgrade Twig to 1.15.* from 1.12.*


There has been some improvements to date handling, speed and error handling.

Change Log Diff:

1.16.2 (2014-10-17)
* fixed timezone on dates as strings
* fixed 2-words test names when a custom node class is not used
* fixed macros when using an argument named like a PHP super global (like GET or POST)
* fixed date_modify when working with DateTimeImmutable
* optimized for loops
* fixed multi-byte characters handling in the split filter
* fixed a regression in the in operator
* fixed a regression in the slice filter

1.16.1 (2014-10-10)
* improved error reporting in a sandboxed template
* fixed missing error file/line information under certain circumstances
* fixed wrong error line number in some error messages
* fixed the in operator to use strict comparisons
* sped up the slice filter
* fixed for mb function overload mb_substr acting different
* fixed the attribute() function when passing a variable for the arguments

1.16.0 (2014-07-05)
* changed url_encode to always encode according to RFC 3986
* fixed inheritance in a 'use'-hierarchy
* removed the __toString policy check when the sandbox is disabled
* fixed recursively calling blocks in templates with inheritance

* 1.15.1 (2014-02-13)
* fixed the conversion of the special '0000-00-00 00:00' date
* added an error message when trying to import an undefined block from a trait
* fixed a C extension crash when accessing defined but uninitialized property.

Proposed resolution

Update Twig to 1.16.* from 1.15.*

Remaining tasks


User interface changes


API changes


#2 2363741-1-upgrade-twig.patch186.93 KBjoelpittet
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,608 pass(es). View
Members fund testing for the Drupal project. Drupal Association Learn more


joelpittet’s picture

Title: Upgrade Twig to 1.15.* from 1.12.* » Upgrade Twig to 1.16.* from 1.15.*
joelpittet’s picture

Status: Active » Needs review
186.93 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,608 pass(es). View
Cottser’s picture

+1, I just want to double check here that we don't need to do anything for the new repo location but it looks like the repo location was changed after 1.16.2 was released and because we're using composer we "should not have to change anything".

joelpittet’s picture

Thanks I didn't know that @Cottser, composer didn't change the URL, though it's not hard coded in the composer.json so I'd have to assume it will magically update when composer looks at the new repo. (my composer was selfupdated before rolling the patch)

Fabianx’s picture

Status: Needs review » Reviewed & tested by the community

RTBC - looks good to me and passes tests.

We want to ship with as new libraries as possible.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed ddfd70a and pushed to 8.0.x. Thanks!

alexpott’s picture

This normal task was committed regardless of #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? since we've agree to keep our dependencies up to date prior to release.

  • alexpott committed ddfd70a on 8.0.x
    Issue #2363741 by joelpittet: Upgrade Twig to 1.16.* from 1.15.*.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.