Problem/Motivation

Book template still have an id in the navigation - that cause the testbot to fail as its using stark instead of classy for testing.
that will stall the work for classy

Proposed resolution

When testbot uses classy remove the id id="book-navigation-{{ book_id }}" from the book template in book/templates

Remaining tasks

fix testbot #2350823: Use the Classy theme in the Testing profile
move booktemplates #2349633: Copy book templates to Classy

User interface changes

API changes

CommentFileSizeAuthor
#4 2363677-removing-the-id.patch611 bytessumanthkumarc

Comments

mortendk’s picture

mortendk commented
Parent issue: » #2349633: Copy book templates to Classy
Related issues: +#2348543: [meta] Consensus Banana Phase 2, transition templates to the starterkit theme
davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented
Issue tags: -testbot +Novice

Those changes have been done. We can do this now. (I believe the ID only appears in book-navigation.html.twig.)

These templates have also been copied to Classy already, so the ID is in the core Book module's template and the template in Classy. Should it be removed from both, or just the Book module one?

sumanthkumarc’s picture

sumanthkumarc commented
Assigned: Unassigned » sumanthkumarc
Issue tags: -Novice +Novice @SprintWeekend2015Queue

Working on it

sumanthkumarc’s picture

sumanthkumarc commented
StatusFileSize
new 2363677-removing-the-id.patch611 bytes

Removed the id="book-navigation-{{ book_id }} from book/templates in book-navigation.html.twig

sumanthkumarc’s picture

sumanthkumarc commented
Status: Active » Needs review
yesct’s picture

yesct commented
Issue tags: -Novice @SprintWeekend2015Queue +Novice, +SprintWeekend2015

tags can be confusing.

Thank you for working on this issue.

Note, tags should be separated with a comma, not a space.

The Queue tag was used to line up issues before the sprint. (#2407325: preparing for a sprint, would be good to have a list of candidate issues)
When you work on an issue please add: SprintWeekend2015 (note, no @ or # at the beginning) according to that and https://groups.drupal.org/node/447258

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented
Status: Needs review » Reviewed & tested by the community

I see nothing attached to that ID so should be good.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

This is consistent with what we've done in other templates, and markup changes are allowed in beta.

Committed and pushed to 8.0.x. Thanks!

  • webchick committed febf423 on 8.0.x 
    Issue #2363677 by sumanthkumarc, davidhernandez: book template id follow...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.