Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Problem/Motivation
Book template still have an id in the navigation - that cause the testbot to fail as its using stark instead of classy for testing.
that will stall the work for classy
Proposed resolution
When testbot uses classy remove the id id="book-navigation-{{ book_id }}" from the book template in book/templates
Remaining tasks
fix testbot #2350823: Use the Classy theme in the Testing profile
move booktemplates #2349633: Copy book templates to Classy
User interface changes
API changes
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | 2363677-removing-the-id.patch | 611 bytes | sumanthkumarc |
Comments
Comment #1
mortendk commentedComment #2
davidhernandezThose changes have been done. We can do this now. (I believe the ID only appears in book-navigation.html.twig.)
These templates have also been copied to Classy already, so the ID is in the core Book module's template and the template in Classy. Should it be removed from both, or just the Book module one?
Comment #3
sumanthkumarc commentedWorking on it
Comment #4
sumanthkumarc commentedRemoved the id="book-navigation-{{ book_id }} from book/templates in book-navigation.html.twig
Comment #5
sumanthkumarc commentedComment #6
yesct commentedtags can be confusing.
Thank you for working on this issue.
Note, tags should be separated with a comma, not a space.
The Queue tag was used to line up issues before the sprint. (#2407325: preparing for a sprint, would be good to have a list of candidate issues)
When you work on an issue please add: SprintWeekend2015 (note, no @ or # at the beginning) according to that and https://groups.drupal.org/node/447258
Comment #7
davidhernandezI see nothing attached to that ID so should be good.
Comment #8
webchickThis is consistent with what we've done in other templates, and markup changes are allowed in beta.
Committed and pushed to 8.0.x. Thanks!