Postponing for 8.1.x being open for development.

Problem/Motivation

Working through #2339151: Conditions / context system does not allow for multiple configurable contexts, eg. language types
found that the Translation annotation class was kind of ill-equipped for non-Plugin-class subclasses.

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Issue category Task because there is no bug and not adding a feature.
Issue priority Normal because not critical, not major (important by community consesus) and also not minor (not cosmetic), so Normal per https://www.drupal.org/core/issue-priority
Unfrozen changes NOT Unfrozen only changes
Prioritized changes This is not a prioritized change for the beta phase.
Disruption NOT Disruptive for core/contributed and custom modules/themes because it will not require a BC break/deprecation/internal refactoring/widespread changes. It is an API addition

So unless this reduces fragility...

not allowed in the beta.

but API additions are allowed in 8.1.x, so postponing till that is open for development.

Proposed resolution

The Translation annotation class would work better in this case if it has a __toString() implementation.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Add automated tests (see comment #3) novice Instructions

User interface changes

No.

API changes

API addition.

Original report by @EclipseGc

CommentFileSizeAuthor
#5 2362727-complete.patch2.32 KBwilsonw
#5 2362727-tests.patch1.86 KBwilsonw
#5 interdiff-2362727-1-5.txt2.32 KBwilsonw
#1 2362727-1.patch471 bytesEclipseGc
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Active » Needs review
FileSize
2362727-1.patch471 bytes
jibran’s picture

jibran
he/him
Primary language Urdu
Location Sydney, Australia
CreditAttribution: jibran commented

Do you think we should add some tests for this?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +Novice

We do already have a unit test for that, so adding support for that test is doable, let's mark this as a novice task.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Issue summary: View changes
Issue tags: +D8MI

adding instructions to the summary for the novice task #3 mentioned.

wilsonw’s picture

wilsonw CreditAttribution: wilsonw commented
FileSize
interdiff-2362727-1-5.txt2.32 KB
2362727-tests.patch1.86 KB
2362727-complete.patch2.32 KB

Giving this test a shot! I think I've located the right file, but I'm not sure about my crude implementation. I saw the testGet function and copied and pasted that to get the testToString function. Will read more on test creation; open to feedback and recommended reading links.

The last submitted patch, 5: 2362727-tests.patch, failed testing.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Version: 8.0.x-dev » 8.1.x-dev
Assigned: EclipseGc » Unassigned
Issue summary: View changes
Status: Needs review » Postponed
Issue tags: -Novice

doing https://www.drupal.org/contributor-tasks/update-allowed-beta
evaluating https://www.drupal.org/contribute/core/beta-changes

removing the novice tag per https://www.drupal.org/core-mentoring/novice-tasks

YesCT’s picture

YesCT CreditAttribution: YesCT commented

@wilsonw it can be frustrating to work on something that gets postponed.

bugs are good candidates for during the drupal 8 beta, maybe one of https://www.drupal.org/project/issues/search/drupal?project_issue_follow... will look interesting to you.

... maybe one that needs tests. writing tests is awesome!

https://www.drupal.org/project/issues/search/drupal?project_issue_follow...

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Status: Postponed » Needs review
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner at Chapter Three commented

@EclipseGc is this still something you want as part of the plugin system?

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc at Acquia commented
Status: Needs review » Closed (outdated)

In the 3+ years since I filed this... I've lost track of what I wanted this for and haven't run into it again so, I think I'm going to close it.

Eclipse

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost as a volunteer and at Skilld commented
Version: 8.5.x-dev » 8.9.x-dev
Status: Closed (outdated) » Needs work
Issue tags: +Needs issue summary update

There's still TODO pointing to the issue https://git.drupalcode.org/project/drupal/blob/8.9.x/core/lib/Drupal/Cor...

Version: 8.9.x-dev » 9.1.x-dev

Drupal 8.9.0-beta1 was released on March 20, 2020. 8.9.x is the final, long-term support (LTS) minor release of Drupal 8, which means new developments and disruptive changes should now be targeted against the 9.1.x-dev branch. For more information see the Drupal 8 and 9 minor version schedule and the Allowed changes during the Drupal 8 and 9 release cycles.

Version: 9.1.x-dev » 9.2.x-dev

Drupal 9.1.0-alpha1 will be released the week of October 19, 2020, which means new developments and disruptive changes should now be targeted for the 9.2.x-dev branch. For more information see the Drupal 9 minor version schedule and the Allowed changes during the Drupal 9 release cycle.

Version: 9.2.x-dev » 9.3.x-dev

Drupal 9.2.0-alpha1 will be released the week of May 3, 2021, which means new developments and disruptive changes should now be targeted for the 9.3.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.3.x-dev » 9.4.x-dev

Drupal 9.3.0-rc1 was released on November 26, 2021, which means new developments and disruptive changes should now be targeted for the 9.4.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.4.x-dev » 9.5.x-dev

Drupal 9.4.0-alpha1 was released on May 6, 2022, which means new developments and disruptive changes should now be targeted for the 9.5.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 9.5.x-dev » 10.1.x-dev

Drupal 9.5.0-beta2 and Drupal 10.0.0-beta2 were released on September 29, 2022, which means new developments and disruptive changes should now be targeted for the 10.1.x-dev branch. For more information see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

Version: 10.1.x-dev » 11.x-dev

Drupal core is moving towards using a “main” branch. As an interim step, a new 11.x branch has been opened, as Drupal.org infrastructure cannot currently fully support a branch named main. New developments and disruptive changes should now be targeted for the 11.x branch, which currently accepts only minor-version allowed changes. For more information, see the Drupal core minor version schedule and the Allowed changes during the Drupal core release cycle.

DavidMV97’s picture

DavidMV97 CreditAttribution: DavidMV97 at SeeD EM for SeeD EM commented
Status: Needs work » Closed (outdated)

I understand that the matter may now be considered outdated and possibly resolved; nevertheless, I have tested patch #5, and it has proven effective for me with PHP 8.1 and MariaDB 10.4