After upgrading to Panopoly 1.12 I started getting this error on PHP 5.4.

Strict warning: Only variables should be passed by reference in      [error]
apps_retrieve_app_image() (line 351 of
/home/travis/build/vih/drupal/profiles/panopoly/modules/contrib/apps/apps.manifest.inc).
Strict warning: Only variables should be passed by reference in      [error]
apps_retrieve_app_image() (line 351 of
/home/travis/build/vih/drupal/profiles/panopoly/modules/contrib/apps/apps.manifest.inc).
Strict warning: Only variables should be passed by reference in      [error]
apps_retrieve_app_image() (line 351 of
/home/travis/build/vih/drupal/profiles/panopoly/modules/contrib/apps/apps.manifest.inc).

https://travis-ci.org/vih/fond-build#L522

CommentFileSizeAuthor
#3 2361927-apps-beta18.patch398 byteshefox

Comments

dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented

Since this is in Apps, can you create an issue in the Apps issue queue and link to it from here?

https://www.drupal.org/node/add/project-issue/apps

Thanks!

lsolesen’s picture

lsolesen commented

Done #2362867: Strict warning: Only variables should be passed by reference in apps_retrieve_app_image()

hefox’s picture

hefox commented
StatusFileSize
new 2361927-apps-beta18.patch398 bytes

Issue was marked as duplicate as was already fixed in -dev/had an existing fixed issue

Anyhow, updating to beta18 should fix it :)

klu’s picture

klu commented
Status: Active » Reviewed & tested by the community

Thanks @hefox for the patch. Confirming that updating to beta18 via patch fixes the issue.

  • dsnopek committed d795537 on 7.x-1.x 
    Update Panopoly Core for #2361927 by hefox | lsolesen: Fixed Strict...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Reviewed & tested by the community » Fixed

Committed, thanks! :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.