Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
22 Oct 2014 at 17:53 UTC
Updated:
16 Nov 2014 at 22:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
rpayanmComment #2
rpayanmComment #3
javivf commentedI have done a reroll and i haven't found the function, only the declaration in file core/includes/unicode.inc
Comment #6
rpayanmComment #7
jamesdixon commentedHere's my attempt at a reroll. A number of functions like hook_theme() were moved from core/modules/system/system.api.php to core/modules/system/theme.api.php causing a conflict in system.api.php. This has been resolved.
Comment #8
rpayanmThe reroll #3 it's a little strange (seem a mix of two patches) and the #7 too.
Comment #9
jamesdixon commentedYou're right in #3 and #7, we were dealing with removing drupal_mail as well, which is outside the scope of this issue.
I double checked the core codebase and can confirm you updated every use of decode_entities() in patch #8 outside of the function definition itself in core/includes/unicode.inc. Looks good to me.
Comment #10
rpayanmThen RTBC...
Comment #11
alexpottCan some one add this issue to the correct change record so we have traceability - once done can be set back to rtbc.
Comment #12
jeroentReferenced this issue on the following change record: New Unicode component
Comment #13
alexpottThis issue is a prioritized change as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed 32913b0 and pushed to 8.0.x. Thanks!