Comments

rpayanm’s picture

Status: Active » Needs review
StatusFileSize
new19.41 KB
rpayanm’s picture

Assigned: rpayanm » Unassigned
javivf’s picture

StatusFileSize
new48.02 KB

I have done a reroll and i haven't found the function, only the declaration in file core/includes/unicode.inc

rpayanm queued 3: 2361789-3.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 3: 2361789-3.patch, failed testing.

rpayanm’s picture

Issue tags: +Needs reroll
jamesdixon’s picture

Status: Needs work » Needs review
StatusFileSize
new46.6 KB

Here's my attempt at a reroll. A number of functions like hook_theme() were moved from core/modules/system/system.api.php to core/modules/system/theme.api.php causing a conflict in system.api.php. This has been resolved.

rpayanm’s picture

StatusFileSize
new19.44 KB

The reroll #3 it's a little strange (seem a mix of two patches) and the #7 too.

jamesdixon’s picture

You're right in #3 and #7, we were dealing with removing drupal_mail as well, which is outside the scope of this issue.

I double checked the core codebase and can confirm you updated every use of decode_entities() in patch #8 outside of the function definition itself in core/includes/unicode.inc. Looks good to me.

rpayanm’s picture

Status: Needs review » Reviewed & tested by the community

Then RTBC...

alexpott’s picture

Status: Reviewed & tested by the community » Needs work
Issue tags: -Needs reroll

Can some one add this issue to the correct change record so we have traceability - once done can be set back to rtbc.

jeroent’s picture

Status: Needs work » Reviewed & tested by the community

Referenced this issue on the following change record: New Unicode component

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

This issue is a prioritized change as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase? and it's benefits outweigh any disruption. Committed 32913b0 and pushed to 8.0.x. Thanks!

  • alexpott committed 32913b0 on 8.0.x
    Issue #2361789 by rpayanm, jamesdixon, javivf: Remove usage of...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.