locale_translation_clear_cache_projects() does not work [#2361415]

Problem/Motivation

locale_translation_clear_cache_projects() tries to clear the the locale_translation_get_projects drupal_static() cache, but does so incorrectly.

This surfaces when installing Drupal via Drush in a different language. Initially the list of projects to install translations for contains only drupal. When later importing translations for other projects, the now stale list is retrieved instead of recalculating the list of projects based on the modules that have been enabled as part of the installation.

When installing through the UI this does not surface because - as always - each installation step is performed in a separate request, thus, the static is irrelevant.

Proposed resolution

Call drupal_static_reset() from locale_translation_clear_cache_projects().

Remaining tasks

User interface changes

API changes

Comment	File	Size	Author
#14	2361415-8-pass.patch	2.39 KB	tstoeckler
#14
#8	2361415-8-pass.patch	2.39 KB	tstoeckler
#8
#8	2361415-8-test-only.patch	1.87 KB	tstoeckler
#8
#3	2361415-3.patch	537 bytes	tstoeckler
#3
#1	2361415-1.patch	517 bytes	tstoeckler
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 22 October 2014 at 11:00

Status:

Active

» Needs review

File	Size
2361415-1.patch	517 bytes

Here we go.

As usual, this whole code path is so convoluted that there is no way to write tests for this. :-/

I also wondered whether there is any value at all in the static, but let's fix the bleeding first.

Comment #2

22 October 2014 at 11:01

Status:

Needs review

» Needs work

The last submitted patch, 1: 2361415-1.patch, failed testing.

Comment #3

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 22 October 2014 at 11:07

Status:

Needs work

» Needs review

File	Size
2361415-3.patch	537 bytes

1 file was hidden/shown/deleted

File	Size
2361415-1.patch	517 bytes

Today is just not my day.

Comment #4

dawehner

German

CreditAttribution: dawehner commented 22 October 2014 at 11:24

Status:

Needs review

» Reviewed & tested by the community

Meh, I guess there is also no way to test that?

Comment #5

tstoeckler

he/him

German

Essen, Germany

CreditAttribution: tstoeckler commented 22 October 2014 at 11:32

I genuinely thought about how to test this, but I have no clue whatsoever. I'm fairly certain it can't be done.

Comment #6

alexpott

he/they

English

🇪🇺🌍

CreditAttribution: alexpott commented 22 October 2014 at 11:41

Status:

Reviewed & tested by the community

» Needs work

Surely this is testable by doing soemthing like

$projects = &drupal_static('locale_translation_get_projects', array());
$projects['test'] = 'test';
locale_translation_clear_cache_projects();
$this->assertEqual(array(), $projects);