In the interest of keeping the code a little cleaner, and using existing code patterns, change to using a colon as the separator instead of dashes in the cache ID.

CommentFileSizeAuthor
#9 panels_hash_cache-n2361251-9.patch4.72 KBdamienmckenna
#5 cleanup_separator_code-2361251-5.patch4.34 KBrahul.shinde
#2 panels_hash_cache-n2361251-2.patch4.35 KBdamienmckenna
#1 panels_hash_cache-n2361251-1.patch4.35 KBdamienmckenna

Comments

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Active » Needs review
StatusFileSize
new panels_hash_cache-n2361251-1.patch4.35 KB

Needs some testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new panels_hash_cache-n2361251-2.patch4.35 KB

A minor adjustment to panels_content_cache_clear_cache().

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs review » Needs work

Needs a reroll.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Assigned: Unassigned » rahul.shinde
rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Assigned: rahul.shinde » damienmckenna
StatusFileSize
new cleanup_separator_code-2361251-5.patch4.34 KB

@DamienMcKenna, Please review the re-rolled patch. If you feel this is okay then we can merge this.

PS. Was unable to produce the interdiff :(

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Status: Needs work » Needs review

Changing status to Needs Review.

The last submitted patch, 2: panels_hash_cache-n2361251-2.patch, failed testing.

Status: Needs review » Needs work

The last submitted patch, 5: cleanup_separator_code-2361251-5.patch, failed testing.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
StatusFileSize
new panels_hash_cache-n2361251-9.patch4.72 KB

This includes one or two minor tweaks.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Needs review
damienmckenna’s picture

damienmckenna
Location TN, USA
commented

The testbots will fail because there are no tests for this module, see #2645590: Ensure that simpletest job doesn't "fail" testing if no tests are present for more details.

Status: Needs review » Needs work

The last submitted patch, 9: panels_hash_cache-n2361251-9.patch, failed testing.

  • DamienMcKenna committed 6d19517 on 7.x-1.x 
    Issue #2361251 by DamienMcKenna, rahul.shinde: Cleaned up...
damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Status: Needs work » Fixed

Committed. Thanks for the help, rahul.shinde!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Assigned: damienmckenna » Unassigned