API page: https://api.drupal.org/api/drupal/core%21modules%21system%21theme.api.ph...

This topic has a couple of minor problems:

a) At the bottom it says "End of ...". This needs to be removed.

b) There's a section header that isn't working right that says @section Assets I think it just needs to say something like "@section assets Assets" (it is missing the section machine name). See
https://www.drupal.org/node/1354#section

CommentFileSizeAuthor
#5 core-themeapi-2359607-5.patch620 byteswilsonw
#3 2359607-3.patch500 bytesrpayanm

Comments

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Assigned: Unassigned » rpayanm

Hello:

I am a novice and I wish fix this, please how I make a patch for documentation pages?
I have made other patches for novices, but not for documentation.

Greetings.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented

There are instructions for making patches on https://www.drupal.org/novice. There are also weekly "office hours" for core mentoring: https://www.drupal.org/core-office-hours -- and see also https://www.drupal.org/contributor-tasks/create-patch (a more concises patch creation guide).

In this case, the documentation that needs to be fixed is in file core/modules/system/theme.api.php in Drupal Core 8.0.x, so if you know how to make patches...

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
Assigned: rpayanm » Unassigned
Status: Active » Needs review
StatusFileSize
new 2359607-3.patch500 bytes

ummm... let me try :)

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Needs work

Thanks! That takes care of item (b) from the issue summary. Item (a) still needs to be done.

wilsonw’s picture

wilsonw commented
StatusFileSize
new core-themeapi-2359607-5.patch620 bytes

Trying to fix part A of this in addition to part B.

My first patch; hope this goes well!

wilsonw’s picture

wilsonw commented
Status: Needs work » Needs review

Changing status to Needs review

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Perfect, thanks!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ab3e679 and pushed to 8.0.x. Thanks!

  • alexpott committed ab3e679 on 8.0.x 
    Issue #2359607 by wilsonw, rpayanm | jhodgdon: Fixed Minor problems on...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.