Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
mail system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Oct 2014 at 21:37 UTC
Updated:
2 Dec 2014 at 12:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jeroentRemoved all usages of drupal_wrap_mail. Patch attached.
Comment #2
jeroentGo testbot!
Comment #3
jeroentCreated follow-up issue to remove the function itself: #2359071: Remove drupal_wrap_mail.
Comment #4
rpayanmminor changes
Comment #5
javivf commentedComment #6
alexpottNot formatted correctly.
Should be a single line. For example the first one could be:
Comment #7
jeroentComment #8
pushpinderchauhan commentedRe-rolled.
Comment #9
rpayanm\Drupal\Core\Mail\MailFormatHelper::wrapMail()-space here-for
Comment #10
gaurav.pahuja commentedAdded required space.
Comment #11
rpayanmLook fine for me :)
Comment #12
alexpottThis should be changed to just:
This is a special format for PHPUnit test method doc blocks that informs code coverage reports what is being tested. The docblock is essentially useless here.
Comment #13
alexpottNeeds works for #12 and since the replacement docblock in #10 breaks code standards by being multi-line.
Comment #14
jeroentMade changes as suggested by alexpott in #2358995-12: Remove usage of drupal_wrap_mail(). Patch attached.
Comment #15
rpayanmFix comments length :)
Comment #18
rpayanmComment #19
Alienpruts commentedMy first attempt at a reroll.
Had to resolve one conflict in file HtmlToTextTest.php :
use Drupal\Component\Utility\String;
use Drupal\Component\Utility\Unicode;
use Drupal\Core\Mail\MailFormatHelper;
use Drupal\Core\Site\Settings;
use Drupal\simpletest\WebTestBase;
I hope I dit it correctly, if not : please advise on what I did wrong and what I should've done :)
PS : yes, i tested the patch against the 8.0.x branch with git apply --check :)
Comment #20
wim leersLooks good!
Comment #21
alexpottThis issue is a prioritized change (deprecated function removal) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed 547a1a0 and pushed to 8.0.x. Thanks!
Minor fixes on commit.