Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
mail system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
17 Oct 2014 at 21:36 UTC
Updated:
4 Dec 2014 at 10:34 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jeroentFirst attempt on removing the drupal_mail_system usages. Patch attached.
Comment #2
rpayanmI found other occurrences.
Comment #3
quietone commentedLooks good, no instances of drupal_mail_system(), except for function itself. Passed tests.
Seems simple enough that I've changed status to RTBC
Comment #4
alexpottLots of the comments can be reflowed to fit the 80 character limit. NB. Only change lines the patch is changing.
Here are the fixes I would make:
Comment #5
rpayanmComment #6
quietone commented@alexpott, @rpayanm, I see.
Reviewed patch from #5, it easier to read now. And grep still only found the declaration of the function drupal_mail_system().
Comment #7
ianthomas_ukNew patch addresses alex's comment
Comment #8
alexpottCan someone attach the relevant change record?
Comment #9
ianthomas_ukIt was refactored in two steps, so two CRs attached.
Comment #10
alexpottThis issue is a prioritized change (removal of deprecated functions) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption. Committed feaabe2 and pushed to 8.0.x. Thanks!