Replace these icons with the Libricon SVGs

See: #1356602: [META] Clean up icons in misc

CommentFileSizeAuthor
#12 Screen Shot 2014-11-08 at 17.02.04.jpg467.54 KBlewisnyman
#11 interdiff-1-11.txt733 bytesBarisW
#11 remove-edit-config-icons-2358685-11.patch2.82 KBBarisW
#1 remove-edit-config-icons-2358685-1.patch1.99 KBAleksandar_P

Comments

Aleksandar_P’s picture

Aleksandar_P commented
Assigned: Unassigned » Aleksandar_P
Status: Active » Needs review
StatusFileSize
new remove-edit-config-icons-2358685-1.patch1.99 KB

I assigned the issue to me.

euphoric_mv’s picture

euphoric_mv commented
Status: Needs review » Reviewed & tested by the community

Tested and patch works fine.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Assigned: Aleksandar_P » Unassigned
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is an unfrozen change as per #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?. Committed 39aeee8 and pushed to 8.0.x. Thanks!

  • alexpott committed 39aeee8 on 8.0.x 
    Issue #2358685 by Aleksandar_P | LewisNyman: Remove edit and configure...
swentel’s picture

swentel commented
Status: Fixed » Needs work

This broke Field UI field buttons. Revert please ?

swentel’s picture

swentel commented

For reference DisplayOverviewBase in Field UI still has a call to configure-dark.png on line 418

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Revert this change - revert ed4cedc and pushed to 8.0.x.

Sorry @swentel :( I thought I grepped the entire code base to make sure.

  • alexpott committed ed4cedc on 8.0.x 
    Revert "Issue #2358685 by Aleksandar_P | LewisNyman: Remove edit and...
lewisnyman’s picture

lewisnyman
he/him
commented
Issue summary: View changes

@swentel Ah sorry. Then the only remaining task is:

Replace the reference to configure-dark.png with the Libricon SVG.

BarisW’s picture

BarisW commented
Status: Needs work » Needs review
StatusFileSize
new remove-edit-config-icons-2358685-11.patch2.82 KB
new interdiff-1-11.txt733 bytes

I believe this nails it.

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen Shot 2014-11-08 at 17.02.04.jpg467.54 KB

Looking good!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a unfrozen change (markup) as per https://www.drupal.org/core/beta-changes and it's benefits outweigh any disruption.. Committed de56864 and pushed to 8.0.x. Thanks!

  • alexpott committed de56864 on 8.0.x 
    Issue #2358685 by BarisW, Aleksandar_P | LewisNyman: Remove edit and...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.