ConfigManager's constructor incorrectly ties itself to the TranslationManager class instead of the TranslationInterface.

CommentFileSizeAuthor
config-manager-translation-interface-hint.patch1.93 KBmikey_p

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Makes sense - rtbc if green.

mikey_p’s picture

mikey_p commented

Seems like the TranslationInterface doesn't really match what's expected of the translation manager, core.services.yml calls initLangaugeManager and then calls addTranslator to add the string_translator service. Should we add those two methods to the TranslationInterface?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

@mikey_p that is a separate issue to this one - the ConfigManager only needs the TranslationInterface part. Also core.services.yml is tied to TranslationManager so if that calls public non interface methods what's actually the problem?

  • catch committed 8e0e7d3 on 8.0.x 
    Issue #2358333 by mikey_p: Fixed ConfigManager should use interface for...
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

This looks fine. @mikey_p please open a new issue for the TranslationInterface change if you think that'd be useful.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.