Problem/Motivation

In #2226533: Changes to the Language class due to the LanguageInterface (followup) and some other issues, people try to correct this "nearby" english error when working on other issues. But the change is out of scope for those issues.

 * @param $flags
 *   (optional) Specifies the state of the languages that have to be returned.
 *   It can be: LanguageInterface::STATE_CONFIGURABLE,
 *   LanguageInterface::STATE_LOCKED, LanguageInterface::STATE_ALL.

Proposed resolution

Just do it in its own separate issue (this issue).

make it

 * @param $flags
 *   (optional) Specifies the state of the languages that have to be returned.
 *   It can be: LanguageInterface::STATE_CONFIGURABLE,
 *   LanguageInterface::STATE_LOCKED, or LanguageInterface::STATE_ALL.

Remaining tasks

Contributor tasks needed
Task Novice task? Contributor instructions Complete?
Create a patch Instructions
Review patch to ensure that it fixes the issue, stays within scope, is properly documented, and follows coding standards Instructions

Tip for reviewers:
ag --literal 'LanguageInterface::STATE_LOCKED, LanguageInterface::STATE_ALL'

or

ag '[\*] *LanguageInterface::STATE_LOCKED'

User interface changes

No.

API changes

No.

CommentFileSizeAuthor
#1 2355573.1.patch2.03 KByesct

Comments

yesct’s picture

yesct commented
Status: Active » Needs review
StatusFileSize
new 2355573.1.patch2.03 KB

just added the or.

filijonka’s picture

filijonka commented
Status: Needs review » Reviewed & tested by the community

This one passes the test and there is no more of these than those in the patch and does what the says it should.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed ba1393b on 8.0.x 
    Issue #2355573 by YesCT: Use English or in some LanguageInterface copy...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.