Follow-up to #2302799-15: InstallerTestBase tests can not be run locally

If I run any of the tests that extend InstallerTestBase, for example DistributionProfileTest it fails.
This failure is caused by not being able to set mysql as database engine, because the radio is disabled if only one engine is available.

CommentFileSizeAuthor
#2 interdiff.txt579 bytespenyaskito
#2 2355523-sqlite-testing-2.patch626 bytespenyaskito
#1 2355523-sqlite-testing-1.patch1.02 KBpenyaskito

Comments

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
Status: Active » Needs review
StatusFileSize
new 2355523-sqlite-testing-1.patch1.02 KB

Remove the driver in the installParameters() method if only one is available.

penyaskito’s picture

penyaskito
he/him
Primary language Spanish
Location 🧑🏽‍🌾 Seville 💃 Andalusia, UTC+2 🇪🇺
commented
StatusFileSize
new 2355523-sqlite-testing-2.patch626 bytes
new interdiff.txt579 bytes

That space shouldn't be there.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Looks great and the non-interactive path will get the correct default value if the driver key is not set.

The last submitted patch, 1: 2355523-sqlite-testing-1.patch, failed testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.0.x. Thanks!

  • webchick committed 1682e49 on 8.0.x 
    Issue #2355523 by penyaskito: Fixed InstallerTestBase tests should not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.