Problem/Motivation

If you install standard you will watchdog entries on every request:

Theme hook toolbar_item not found.

This was caused by a "merge conflict" between:

#2226207: Make 'template' the default output option for hook_theme()

diff --git a/core/modules/toolbar/toolbar.module b/core/modules/toolbar/toolbar.module
index fb47469..3d960a8 100644
--- a/core/modules/toolbar/toolbar.module
+++ b/core/modules/toolbar/toolbar.module
@@ -42,9 +42,6 @@ function toolbar_theme($existing, $type, $theme, $path) {
     'render element' => 'element',
     'template' => 'toolbar',
   );
-  $items['toolbar_item'] = array(
-    'render element' => 'element',
-  );
 
   return $items;
 }

and #2326895: Convert toolbar_element_info() to Element classes

Proposed resolution

Drop the line:
'#theme' => 'toolbar_item',from ToolbarItem.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#3 watchdog_entries_caused-2354699-3.patch501 bytesmpdonadio

Comments

jazio’s picture

Assigned: Unassigned » jazio
jazio’s picture

Assigned: jazio » Unassigned

I am sorry I cannot reproduce it.

mpdonadio’s picture

Status: Active » Needs review
StatusFileSize
new501 bytes

I was able to reproduce this. The proposed resolution seems to work for me. Let's see if TestBot complains.

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Awesome! This saves quite some time for the admin user on requests which do render the toolbar.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed fa63f19 and pushed to 8.0.x. Thanks!

  • alexpott committed fa63f19 on
    Issue #2354699 by mpdonadio | dawehner: Fixed Watchdog entries caused by...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.