Problem/Motivation
If you install standard you will watchdog entries on every request:
Theme hook toolbar_item not found.
This was caused by a "merge conflict" between:
#2226207: Make 'template' the default output option for hook_theme()
diff --git a/core/modules/toolbar/toolbar.module b/core/modules/toolbar/toolbar.module
index fb47469..3d960a8 100644
--- a/core/modules/toolbar/toolbar.module
+++ b/core/modules/toolbar/toolbar.module
@@ -42,9 +42,6 @@ function toolbar_theme($existing, $type, $theme, $path) {
'render element' => 'element',
'template' => 'toolbar',
);
- $items['toolbar_item'] = array(
- 'render element' => 'element',
- );
return $items;
}
and #2326895: Convert toolbar_element_info() to Element classes
Proposed resolution
Drop the line:
'#theme' => 'toolbar_item',from ToolbarItem.
Remaining tasks
User interface changes
API changes
Comments
Comment #1
jazio commentedComment #2
jazio commentedI am sorry I cannot reproduce it.
Comment #3
mpdonadioI was able to reproduce this. The proposed resolution seems to work for me. Let's see if TestBot complains.
Comment #4
dawehnerAwesome! This saves quite some time for the admin user on requests which do render the toolbar.
Comment #5
alexpottCommitted fa63f19 and pushed to 8.0.x. Thanks!