During uninstalling the module variables of advance clock are not getting flushed from variable table. Which unnecessary fludding the variable table in database.

CommentFileSizeAuthor
#6 variables_are_getting-2354385-6.patch994 bytesrahul.shinde
#3 advance_clock-remove-variable-during-uninstallation-2354385-3.patch1.27 KBsmashwini

Comments

smashwini’s picture

smashwini commented
Issue summary: View changes
smashwini’s picture

smashwini commented
Version: 7.x-1.x-dev » 7.x-1.2
smashwini’s picture

smashwini commented
Version: 7.x-1.2 » 7.x-1.x-dev
Status: Active » Needs review
StatusFileSize
new advance_clock-remove-variable-during-uninstallation-2354385-3.patch1.27 KB

Added hook_uninstall with db_delete query to delete all variables of module from system variable table during module uninstall.

sharique’s picture

sharique commented
Status: Needs review » Reviewed & tested by the community

This patch looks good to me.

rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Assigned: smashwini » rahul.shinde
Status: Reviewed & tested by the community » Needs review
rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
StatusFileSize
new variables_are_getting-2354385-6.patch994 bytes

Here is the new patch, hope this suits the purpose.

  • rahul.shinde committed 620d7b0 on 7.x-1.x 
    Issue #2354385 by rahul.shinde, ashwinikumar: Fixed Variables are...
rahul.shinde’s picture

rahul.shinde
he/him
Primary language Marathi
Location Pune
commented
Status: Needs review » Fixed

  • ravyg committed 386eeac on 7.x-1.x authored by rahul.shinde 
    Issue #2354385 by rahul.shinde: Fixed clear cache all function with...
  • ravyg committed d1435bb on 7.x-1.x
    Issue #2354385 by ravyg: Fixing authorship issue rebase code
  • ravyg committed d162199 on 7.x-1.x authored by ashwinikumar
    Issue #2354385 by ashwinikumar: Fixed Variables are getting left in...
ravyg’s picture

ravyg commented
Assigned: rahul.shinde » ravyg

Fixing authorship conflict.
- Reverting code
- Applying required authorships

ravyg’s picture

ravyg commented
Status: Fixed » Closed (works as designed)