We have a huge list of IP addresses for one of our sites so we need a lot more space than 255 chars. And we don't want to use the 3.x version because we don't want to enter all address as separated fields. That would be to much work.

I have made a patch where I have changed ip_match to a text instead, and on the settings form I changed to a textarea and allowed the user to enter IP addresses per line as well as comma separated.

CommentFileSizeAuthor
#2 ip_login-change_data_type_of_ip_match_field-2354067-2.patch1.79 KBpachabhaiya
#1 change_ip_match_to_text-2354067-1.patch4.34 KBlogaritmisk

Comments

logaritmisk’s picture

logaritmisk commented
Status: Active » Needs review
StatusFileSize
new change_ip_match_to_text-2354067-1.patch4.34 KB
pachabhaiya’s picture

pachabhaiya commented
StatusFileSize
new ip_login-change_data_type_of_ip_match_field-2354067-2.patch1.79 KB

Patch #1 works good in the clean 7.x-2.0 branch.

But,
I already have this patch applied in 7.x-2.0 branch.
Now, I just want to update the data type of 'ip_match' field to support more ip addresses.
Patch #1 fails for me because I already have another patch applied.

I'm adding a minimal version of new patch just to update the data type of ip_match field so that it works cleanly even if the other patch is already applied.

amateescu’s picture

amateescu commented
Status: Needs review » Closed (outdated)

Closing old issues.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.