Problem/Motivation

The update_check_frequency variable does not have a migration to D8 (update.settings).

Proposed resolution

Create the migration.

Remaining tasks

Create the migration, write the test.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#4 2353711-4.patch2.21 KBjarsenx
#2 2353711-2.patch2.21 KBjarsenx

Comments

jarsenx’s picture

jarsenx commented
Assigned: Unassigned » jarsenx
jarsenx’s picture

jarsenx commented
Status: Active » Needs review
StatusFileSize
new 2353711-2.patch2.21 KB

Fixed migration issue for update_check_frequency variable.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Needs work

Joe - just one quick fix...

+++ b/core/modules/migrate_drupal/src/Tests/Dump/Drupal6UpdateSettings.php
@@ -37,6 +37,11 @@ public function load() {
+    ))    ¶

I'm going to be picky here, but please remove these extra spaces.

-mike

jarsenx’s picture

jarsenx commented
Status: Needs work » Needs review
StatusFileSize
new 2353711-4.patch2.21 KB

Updated patch based on code review.

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Reviewed & tested by the community

Looks great - thanks!

-mike

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed d79c585 and pushed to 8.0.x. Thanks!

  • alexpott committed d79c585 on 8.0.x 
    Issue #2353711 by jarsenx | ultimike: D6->D8 Migration missing variable...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.