Problem/Motivation

The allow_insecure_uploads variable does not have a migration to D8 (system.file).

Proposed resolution

Create the migration.

Remaining tasks

Create the migration, write the test.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#6 2353683-6.patch2.04 KBmicnap
#3 2353683-3.patch2.04 KBmicnap

Comments

ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Issue summary: View changes
micnap’s picture

micnap commented
Assigned: Unassigned » micnap
micnap’s picture

micnap commented
StatusFileSize
new 2353683-3.patch2.04 KB

Patch attached.

micnap’s picture

micnap commented
Status: Active » Needs review
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Needs work

Mickey,

My bad - I forgot to mention that TRUE/FALSE should be in all caps...

  1. +++ b/core/modules/migrate_drupal/config/install/migrate.migration.d6_system_file.yml
@@ -7,9 +7,16 @@ source:
+      0: false
+      1: true

    Should be all caps: TRUE and FALSE. 

  2. +++ b/core/modules/migrate_drupal/src/Tests/d6/MigrateSystemFileTest.php
@@ -41,6 +41,7 @@ public function testSystemFile() {
+    $this->assertIdentical($config->get('allow_insecure_uploads'), true);

    Should be all CAPS: TRUE.

Thanks,
-mike

micnap’s picture

micnap commented
StatusFileSize
new 2353683-6.patch2.04 KB

Ah yes. Forgot that. Here's a new patch.

micnap’s picture

micnap commented
Status: Needs work » Needs review
ultimike’s picture

ultimike
Primary language English
Location Florida, USA
commented
Status: Needs review » Reviewed & tested by the community

Sweet. Look good to me!

Thank you!

-mike

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed f2cb144 and pushed to 8.0.x. Thanks!

  • alexpott committed f2cb144 on 8.0.x 
    Issue #2353683 by micnap | ultimike: D6->D8 Migration missing variable:...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.