Problem/Motivation
I cannot save the FTP settings when trying to install a module from the UI (with both url and tarball module)
See attached picture.
Ok after a first check it appears that the button is just hidden and don't show up when it should. But once the button shown, give the settings a working account and FTP server, I'm redirecting to the error page with no information.
By the way, I only see "FTP" in the select list, is there any way to choose to upload by SFTP & SSH?
How to reproduce
Install a new module from the administration
Fill the form for the FTP connection
Display the "Continue" button with the console
Cry
Proposed resolution
Need to fix the show/hide of the continue button
Need to fix the upload actually not working
Remaining tasks
Fixing the hide/show on the "Continue" button.
Inspect the FTP connection with fresh settings throwing an exception without error messages.
Comment | File | Size | Author |
---|---|---|---|
#15 | authorize-missing-library-2353335-15.patch | 3.66 KB | Wim Leers |
Comments
Comment #1
myforgedoteu CreditAttribution: myforgedoteu commentedComment #2
myforgedoteu CreditAttribution: myforgedoteu commentedComment #3
catchComment #4
Devin Carlson CreditAttribution: Devin Carlson commentedConfirmed that the button is hidden by a rule in system.maintenance.css introduced in #1574484: Selectors clean-up: authorize.js.
Attempting to duplicate the problem with tests, though I also ran into other issues with update.module and have tried to add test coverage for those bugs as well.
Comment #6
catchComment #7
Devin Carlson CreditAttribution: Devin Carlson commentedMoving the other problems into separate issues.
It looks like the core issue here is related to #2376147: Installer is missing all of the global Seven theme stylesheets. The
core/drupal.states
library is not being added to the page so the JS files that make up the States API are missing, resulting in the form elements being hidden.The attached patch conflicts with the related issue but demonstrates the problem.
Comment #10
Devin Carlson CreditAttribution: Devin Carlson commentedReroll now that #2376147: Installer is missing all of the global Seven theme stylesheets got in.
Comment #11
Wim LeersThis is wrong; it should not be attached via
hook_page_attachments()
, because this causes this library to be attached on all pages.If
#states
is used inFileTransferAuthorizeForm
, then this library should be attached there.Comment #14
Wim LeersThis was implicitly broken by #2273277: Figure out a solution for the problematic interaction between the render system and the theme system when using #pre_render.
Fix attached.
The problem was that
#attached
essentially was thrown away, because it's rendered very early and then just a string of HTML is passed in for final rendering… which doesn't know about the needed attached assets!Comment #15
Wim LeersOne bit of cleanup for #14.
Comment #16
Devin Carlson CreditAttribution: Devin Carlson commentedThe changes in #15 look good and fixed the issue in my testing.
Comment #17
alexpottThis issue addresses a critical bug and is allowed per https://www.drupal.org/core/beta-changes. Committed b6c1c2f and pushed to 8.0.x. Thanks!