On two sites I'm getting the following error. I had that plugin bundled-into the builder download and the error still remains. So, I downloaded the plugin separately and placed it in the plugins folder and the error is still persisting after an update.php run, cron run and two cache flushes on two sites.

Quick Edit: CKEditor's "Source" button is used "Source Dialog" CKEditor plugin missing
This plugin is necessary to keep the "edit source" functionality while in-place editing.
Please create a custom build of CKEditor that includes this plugin.

The patch for underscore in another issue fixed that issue, but this one still lingers.
#2337497: Underscore version >=1.7 not detected using Libraries API

CKEditor library: 4.4.5
CKEditor module: 7.x-1.16

Comments

deanflory’s picture

Issue summary: View changes
deanflory’s picture

Issue summary: View changes
Kruggy’s picture

Hi,

To copy /sites/all/modules/ckeditor/ckeditor in /sites/all/libraries/ckeditor, seems to solve the issue.

Message comes from file quickedit.install

...
      if (!libraries_get_path('ckeditor')) {
        $requirements['quickedit_libraries_ckeditor']['value'] = t('Install the CKEditor library in a standard location. (!doc)', array('!doc' => l(t('Documentation'), 'https://drupal.org/node/1440066', array('external' => TRUE))));
        $requirements['quickedit_libraries_ckeditor']['severity'] = REQUIREMENT_ERROR;
      }

      $ckeditor_js = file_get_contents(libraries_get_path('ckeditor') . '/ckeditor.js');

...

     if (FALSE !== strpos($ckeditor_js, 'CKEDITOR.plugins.add("sourcedialog"')) 

libraries_get_path function seems to look inside librarie dir, or I install ckeditor librarie in module dir due to COPY_HERE.txt file in module/ckeditor/ckeditor

Go to http://ckeditor.com and download the latest version. Then uncompress the contents of the "ckeditor" directory of the downloaded file to This folder (modules/ckeditor/ckeditor).

May be I am wrong, but I have no more the error message.

deanflory’s picture

I have my ckeditor library in my libraries folder and not in the module folder.

vgutekunst’s picture

Same problem here. Any solution? Ckeditor is in module and Ckeditor libaries in sites/all/libraries

i tried ckeditor 4.4.3, 4.4.7 etc.

Quick Edit: Backbone library 1.1.2 (minified) OK
Quick Edit: CKEditor library Exists, compatible and correct location

BUT still this errors:

"Shared Space" CKEditor plugin missing

"Source Dialog" CKEditor plugin missing

any idea?

UPDATE:

after i used this CKeditor it works:

The CKEditor team graciously provides a Quick Edit-optimized build of CKEditor: http://download.cksource.com/CKEditor%20for%20Drupal/edit/ckeditor_4.4.3... — this is the easiest way to get started!

askibinski’s picture

I understand the decision of using a custom ckeditor built, but it doesn't seem necessary. Quickedit works fine if you just add the plugins needed, but hook_requirement checks ckeditor.js if the plugin is enabled.

However, if you use ckeditor module and have the plugins enabled through the module interface, the errors will keep up displaying because they are not included in ckeditor js.

In my opinion, the solution would be to ALSO check all CKEditor profiles, and see if the plugins are enabled there:

Here is some quick starter code, but I think the whole hook_requirements could use some refactoring.

      $profiles_list = ckeditor_profile_input_formats();
      $required_plugins['sharedspace'] = FALSE;
      $required_plugins['sourcedialog'] = FALSE;
      foreach ($profiles_list AS $_profile => $_inputs) {
        $profile = ckeditor_profile_load($_profile);
        foreach (array_keys((array) $profile->settings['loadPlugins']) as $plugin_name) {
          if (isset($required_plugins[$plugin_name])) {
            $required_plugins[$plugin_name] = TRUE;
          }
        }
      }
....
     if ($required_plugins['sourcedialog'] || FALSE !== strpos($ckeditor_js, 'CKEDITOR.plugins.add("sourcedialog"')) {
       // don't show error
     }
...

However, it gets a bit complicated because there could be several ckeditor profiles and not every profile might have the plugins enabled. But then again, this might be by choice: it could be that some roles don't have permission to use inline editting at all.

izmeez’s picture

I'm not seeing this problem with current quickedit-7.x-1.x-dev and ckeditor-4.5.4 library with "Shared Space" and "Source Dialog" plugins included. I may have disabled and re-enabled quickedit module.

brandy.brown’s picture

What happened to the optimized build of ckeditor? http://download.cksource.com/CKEditor%20for%20Drupal/edit/ckeditor_4.4.3 ... when I used that in the past, quickedit worked as expected. Now I can't get it to recognize needed plugins.

EDIT ---
I uploaded the optimized build for others who might be looking for it.

brandy.brown’s picture

StatusFileSize
new1.34 MB
kurtfoster’s picture

StatusFileSize
new899.3 KB

Here's a 4.5.6 version with Sharedspace and Source Dialog

deanflory’s picture

I am still having these errors after downloading the "Full" download, copying all required plugins into the plugins folder, and editing the build-config.js file to include the plugins:

Error
Quick Edit: CKEditor's "Shared Space" plugin is included "Shared Space" (link is external) CKEditor plugin missing
This plugin is essential for CKEditor to work with in-place editing.
Please create a custom build (link is external) of CKEditor that includes this plugin.
Error
Quick Edit: CKEditor's "Source" button is used "Source Dialog" (link is external) CKEditor plugin missing
This plugin is necessary to keep the "edit source" functionality while in-place editing.
Please create a custom build (link is external) of CKEditor that includes this plugin.

After deleting the manually customized version and uploading a custom build from ckeditor.com but manually adding the plugins iframedialog, lineutils, and sharedspace to the plugins folder (even though they were all included in the custom build but I guess incorporated in other ways that didn't require them needing a plugin folder in the plugin folder) I get no errors.

I'm guessing that one must edit the config.js and not just the build-config.js file? That's awfully complicated code in there just to add a plugin (and therefore defeats the whole purpose of "plug-in").

prdsp’s picture

Thanks Dean I downloaded the custom build at ckeditor.com with the iframedialog, lineutils, sharedspace & sourcedialog added to the build...then I separately downloaded the iframedialog, lineutils, & sharedspace plugins from ckeditor.com and manually added those folders to my ckeditor plugins folder and it worked...and I didn't even need to edit the config.js or build-config.js files...just left them as they are and everything still worked.

brandonc503’s picture

same issue.

andzejsw’s picture

I have actually fixed this!

1. First create ckeditor trough builder page (ckeditor.com/builder) or download plugins manually and insert them in libraries/ckeditor/plugins folder.
2. Insert in config.js (located in \sites\all\libraries\ckeditor) ckeditor function these two lines:
config.extraPlugins = 'sharedspace';
config.extraPlugins = 'sourcedialog';
3. Disable and Enable "quick edit" module.

If that doesn't work, check if quickedit.install contains this code:
"$ckeditor_js = file_get_contents(libraries_get_path('ckeditor') . '/ckeditor.js');"

PS: Sorry about my bad english.

jalpesh’s picture

I was also facing the same issue. comment #9 solved the problem.

I have also try solution of #14 but didn't work for me. Thanks.

prashantgajare’s picture

StatusFileSize
new1.03 MB

I was facing this issue and comment #9 solved the problem related to this. Also tested against the latest new version of the CKEditor i.e. 4.7.0 and the issue was resolved for me

Uploaded 4.7.0 version with Sharedspace and Source Dialog.

prashantgajare’s picture

tonka67’s picture

#16 worked for me. Finally. Thanks @prashantgajare.

dx007’s picture

#9 works good for me!
Thank you brandy.brown

kris77’s picture

#16 works for me too.
Thanks @prashantgajare

vladimiraus’s picture

Status: Needs work » Closed (outdated)

Thank you for your contributions. 🎂
Drupal 7 is no longer supported. 🚀
Marking as outdated.

Now that this issue is closed, review the contribution record.

As a contributor, attribute any organization that helped you, or if you volunteered your own time.

Maintainers, credit people who helped resolve this issue.