PBX_HMAC method

Just a note: there already is no need for the CGI module if you use the PPPS method for Paybox. Anyway, I'll let you work on the patch. Thanks!

Hello,

Thanks for the patch.

I test without it, and the offsite payment method fail, in the error message it says that it require the CGI bin.

I don't know if I can test with it because I don't have paybox account. Is there an API provided by paybox to have a test gateway ?

I review your patch, I don't have a lot of things to say : mainly coding style standards, and the next point.

+++ b/commerce_paybox.module
@@ -229,51 +229,85 @@ function commerce_paybox_offsite_redirect_form($form, &$form_state, $order, $pay
+    // code as paybox's example to generate HMAC key
+    $keyTest = variable_get('commerce_paybox_hmac_key','');
+    $binKey = pack("H*", $keyTest);
+    $hash = strtolower($pbx_params['PBX_HASH']);
+    $hmac = strtoupper(hash_hmac($hash, $msg, $binKey));
+    $pbx_params['PBX_HMAC'] = $hmac;

I don't understand this part as there is already a variable_get to go in this part of the if ... else .. statement

Thanks for the patch.

EDIT : maybe in the .install file, you should add variable_del for the new variables you introduce.

Hello,

I attach a patch where I have fixed all the coding styles issues to not losing time in long patch exchanges.

The problems were mostly:

• array('value1','value2') => array('value1', 'value2') : space after comma
• Comments should starts with a capital letter and end with a point
• indentation as tabulations instead of spaces
• no capital letters in variable name
• space before and after '=' sign and concatenation

I have nothing else to say.

I can't help you any more because I can't test if it is functionnal with the paybox API.

Thanks for your patch. Hoping it will be merged as soon as possible :)

Hi !

thank you very much dgeo, that's just what I needed and it saved me a lot of work !
I just had to change one thing in your patch : The $hmac musn't be in lowercase as it is set in uppercase in the form. This causes the Paybox system to return an error cause it makes the the hash and the form data different.

   // Code as paybox's example to generate HMAC key.
   $binkey = pack("H*", $hmac_key);
-  $hash = strtolower($pbx_params['PBX_HASH']);
+  $hash = $pbx_params['PBX_HASH'];
   $hmac = strtoupper(hash_hmac($hash, $msg, $binkey));
   $pbx_params['PBX_HMAC'] = $hmac;
}

Except that point, your patch worked like a charm !

Hello,

Is this patch will be add to a new release soon ??

Thanks.

If I understand correctly, this patch removes the need for a CGI module, am I right?

Since several people are confirming it works, I'm willing to commit it. But I'm unable to release a new version (I have not the right), so it will live in the -dev version for now...).

Yes, that's it. This removes the need of CGI module.
Thanks for the dev !

Works as expected. I check the algo and if is ok. All listed HMAC algos are supported in the first version of PHP where hash_hmac() was introduced.

In the attached patch there are a few more modification: correct some words and rename variables to match their meaning, so I'll keep the issue as RTBC.

Ooops the patch was diff'ed against master instead of 7.x-1.x.

Alright, committed. Let me know if the -dev version (in a few hours) is correctly working, I'll eventually tag a new one.
Thanks for all the work and collaboration on the issue, and my apologies for the delay!

The latest -dev version doesn't work for me. I don't want to use the PBX_HMAC method so, I let the key empty but I have an 'unknown shop' error when I'm redirected to the Paybox page. I found a missing line in the code. Here is a patch which solved my problem.

HMAC method works well for me, thanks for your patch !

The patch has been applied to the dev branch, switching it to fixed.