Simplify $language max weight code using max()

Working on this...

Thanks. That looks good.

was there something else you wanted to work on? unassigning since it was green and want to be able to continue to move this issue forward. comment here or ping me irc if you were in the middle of something.

I'm not sure how many places we want to look for patterns like that, but I think we can do both that were in #2304403: Convert language:weight into a protected property.

There is another in ConfigurableLanguageManager.

fixed :D

thanks.

--
I took a look at the patch.

+++ b/core/modules/language/src/Tests/LanguageConfigurationTest.php
@@ -167,14 +167,14 @@ protected function checkConfigurableLanguageWeight($state = 'by default') {
-  protected function getHighestConfigurableLanguageWeight(){
+  protected function getHighestConfigurableLanguageWeight() {

out of scope for this issue.

--
the rest looks ok.

--
Note https://drupal.org/documentation/git/interdiff is really nice when working on an issue that has a previous patch. It really helps reviewers.

sorry, here the patch and interdiff for you last correction :)

this looks super. improves just the two from the other patch that @dawehner spotted.

Committed 8b24674 and pushed to 8.0.x. Thanks!