EntityInterface::getSystemPath() should be marked deprecated so we communicate that it will be removed before release.

CommentFileSizeAuthor
#4 2350835-4.patch599 bytespwolanin
#2 2350835-2.patch608 bytespwolanin

Comments

pwolanin’s picture

pwolanin commented
Issue summary: View changes
Parent issue: » #2339219: [meta] Finalize URL generation API (naming, docs, deprecation)
pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 2350835-2.patch608 bytes

simple deprecation comment

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Entity/EntityInterface.php
@@ -171,6 +171,9 @@ public function link($text = NULL, $rel = 'canonical', array $options = []);
+   *    EntityInterface::urlInfo() instead.

Let's use static::

pwolanin’s picture

pwolanin commented
Priority: Major » Critical
Status: Needs work » Needs review
StatusFileSize
new 2350835-4.patch599 bytes

ok, sure

also, catch says "critical"

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Quickfix

Yeah sorry for that nitpick.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 46ec5d9 on 8.0.x 
    Issue #2350835 by pwolanin: Mark EntityInterface::getSystemPath() as...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.