Closed (duplicate)
Project:
Drupal core
Version:
8.0.0-beta1
Component:
quickedit.module
Priority:
Normal
Category:
Support request
Assigned:
Unassigned
Reporter:
Created:
5 Oct 2014 at 01:22 UTC
Updated:
4 Dec 2014 at 13:37 UTC
Jump to comment: Most recent
Comments
Comment #1
slawrence10 commentedComment #2
wim leersDo you see any JavaScript errors in the console? Do other contextual links work?
Comment #3
Kyna commentedSimilar problem after the installation of a custom theme.
detailed error: DrupalBehaviorError: attach ; quickedit: entityElement.get(...) is undefined
DrupalBehaviorError.prototype = new Error();
Comment #4
wim leers#3: That's possible if your theme is stripping or omitting certain things, see http://cgit.drupalcode.org/quickedit/tree/README.txt?id=feb4c9dd43edfe34... and please report back.
Comment #5
Kyna commentedHello, and thanks for the link Wim Leers.
You can see my current work here :
http://i.imgur.com/joGSaVd.jpg
The title "h1" is displayed after my breadcrumb block inside a custom .html.twig file :
Comment #6
Kyna commentedAnd if I look the JS, we have this line :
entityElement.getAttribute('data-quickedit-entity-id');
The error :
detailed error: DrupalBehaviorError: attach ; quickedit: entityElement.get(...) is undefined
The "data-quickedit-entity-id" attribute is defined inside the node.html.twig template with the {{ attributes.addClass(classes) }} variable, but I don't have defined/overwrite this template, I have only custom page.html.twig, you can see this parameters inside my final html here :
http://i.imgur.com/BcU3n7E.png
Edit: I have this JS problem on all my pages, and on my contact page (page without customizable node).
Comment #7
Kyna commentedComment #8
wim leersWait, what? Are you hardcoding this attribute in your Twig templates? You must not do that, the Quick Edit module will do that for you automatically.
We could resolve this very, very quickly if you could give me access to your site (or alternatively: send me the code of your theme). Contact me via my drupal.org contact page if it's not a public site.
Comment #9
Kyna commentedDuplicateComment #10
Kyna commentedThanks, My complete Layout :
Comment #11
Kyna commentedComment #12
wim leersThat's your
page.html.twig. Is that the only template you're overriding? Because it generally doesn't matter what you do there; it doesn't affect Quick Edit.Except if the title field is the problem. The
page.html.twigtemplate should be printing the title, but it's not doing that for you.Comment #13
Kyna commentedI have :
page.html.twig :
{% extends "@bootstrap/layout/layout.html.twig" %}layout.html.twig :
My page title is inside my breadcrumb.html.twig.
breadcrumb.html.twig :
The title/breadcrumb is displayed on all my pages/articles/etc.
You can see my Title/Breadcrumb area here : http://i.imgur.com/joGSaVd.jpg
The breadcrumb is not displayed here because bug in DRupal 8 at the moment.
You can see my complete layout code inside my previous message.
Else I have this errors displayed by drupal on my design on all node/article in my design :
User error: "text" is an invalid render array key in Drupal\Core\Render\Element::children() (line 93 of core/lib/Drupal/Core/Render/Element.php).
User error: "text" is an invalid render array key in Drupal\Core\Render\Element::children() (line 93 of core/lib/Drupal/Core/Render/Element.php).
The two errors is displayed twice by page on message area and inside "/admin/reports/dblog".
Drupal say : Type of error : PHP.
Comment #14
Kyna commentedComment #15
wim leersI said:
But I'm afraid these templates don't help me; they look fine. Could you give me access to the site, so I can debug it?
Comment #16
Kyna commentedI create a online version today :)
Comment #17
Kyna commentedIt's done :
--
An article : http://aquaflora.fr/node/1
A node : http://aquaflora.fr/node/8
Errors displayed after title and breadcrumb.
And on Homepage, when I hover the header or footer, the drupal icon for "edit view" is displayed, it's an error I think.
ps: Drupal 8 don't load jquery for visitors ?
Thank you :)
Comment #18
wim leersThanks! Now I managed to reproduce and track down the problem :)
The problem you're seeing is a duplicate of #2284917: In-place editing of custom blocks broken *again* (because attributes and contextual links of custom blocks are lost). Apply that patch and it'll be fixed. Please try that patch, that patch will be committed before 8.0.0 ships of course.
Comment #19
Kyna commentedNice! But how I can apply a patch please ? This patch by example : https://www.drupal.org/files/issues/block_content_in_place_editing-22849...
I see many files inside the issue of your link, but I don't understand how it works, it's my first time with Drupal Patch.
Thank you :)