The comment.html.twig contains a 'new' class. The comment-new-indicator.js adds this class if needed, so the 'new' class is redundant in the template.

Patch follows.

CommentFileSizeAuthor
#3 comments-new-indicator.png212.56 KBBarisW
#1 remove-stray-new-class-2350505-1.patch648 bytesBarisW

Comments

BarisW’s picture

BarisW commented
Status: Active » Needs review
Issue tags: +Amsterdam2014, +frontend, +Twig, +CSS, +Novice
StatusFileSize
new remove-stray-new-class-2350505-1.patch648 bytes
fabianx’s picture

fabianx commented
Status: Needs review » Reviewed & tested by the community

Good catch, and even very important for proper render caching to have at least dependent classes as possible :).

I assume you tested that the new class is still present for new comments ...

BarisW’s picture

BarisW commented
StatusFileSize
new comments-new-indicator.png212.56 KB

Yes, to proof: here's a screenshot.

Don't you just love it?

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 3d938a3 and pushed to 8.0.x. Thanks!

  • alexpott committed 3d938a3 on 8.0.x 
    Issue #2350505 by BarisW: Fixed Remove stray 'new' class on comments.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.