Problem/Motivation

For some reason we normalize the data before proxying the call to encode on our base encoder in \Drupal\serialization\Encoder\XmlEncoder.

Proposed resolution

Remove this call, don't extend the SerializerAwareEncoder anymore.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 interdiff-2349879-4.txt825 bytesdamiankloip
#4 2349879-4.patch2.35 KBdamiankloip
d8-xmlencoder.patch2.07 KBdamiankloip

Comments

damiankloip’s picture

damiankloip commented
Status: Active » Needs review
damiankloip’s picture

damiankloip commented
Title: Remove unnecessary call to normalize dat ain XmlEncoder::encode » Remove unnecessary call to serializer > normalize in XmlEncoder::encode

Status: Needs review » Needs work

The last submitted patch, d8-xmlencoder.patch, failed testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
StatusFileSize
new 2349879-4.patch2.35 KB
new interdiff-2349879-4.txt825 bytes

Mehh

Status: Needs review » Needs work

The last submitted patch, 4: 2349879-4.patch, failed testing.

damiankloip queued 4: 2349879-4.patch for re-testing.

damiankloip’s picture

damiankloip commented
Status: Needs work » Needs review
dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Nice catch!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 428ff5b and pushed to 8.0.x. Thanks!

  • alexpott committed 428ff5b on 8.0.x 
    Issue #2349879 by damiankloip: Fixed Remove unnecessary call to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.