Problem/Motivation

The method drupalGetSettings on the abstract class WebTestBase is deprecated. We should use getDrupalSettings instead.

Proposed resolution

Replace all drupalGetSettings() by getDrupalSettings().

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#1 remove-deprecated-drupalgetsettings-2349851-1.patch9.39 KBtargoo

Comments

targoo’s picture

targoo commented
Status: Active » Needs review
StatusFileSize
new remove-deprecated-drupalgetsettings-2349851-1.patch9.39 KB

Here is the patch. ready to be reviewed ;-)

Status: Needs review » Needs work

The last submitted patch, 1: remove-deprecated-drupalgetsettings-2349851-1.patch, failed testing.

Status: Needs work » Needs review

targoo queued 1: remove-deprecated-drupalgetsettings-2349851-1.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: remove-deprecated-drupalgetsettings-2349851-1.patch, failed testing.

Status: Needs work » Needs review

prics queued 1: remove-deprecated-drupalgetsettings-2349851-1.patch for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

NO leftover usages of drupalGetSettings() left.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 1: remove-deprecated-drupalgetsettings-2349851-1.patch, failed testing.

Status: Needs work » Needs review

yukare queued 1: remove-deprecated-drupalgetsettings-2349851-1.patch for re-testing.

skipyT’s picture

skipyT commented
Status: Needs review » Reviewed & tested by the community

this seems ok.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed aaab927 on 8.0.x 
    Issue #2349851 by targoo: Remove uses of the deprecated...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.