In the delete() method of the EntityStorageBase, there is a small error in a code comment.

    if (!$entities) {
      // If no IDs or invalid IDs were passed, do nothing.
      return;
    }

Actually, the IDs of the array passed don't really matter. The following should be more accurate:

    if (!$entities) {
      // If no entities were passed, do nothing.
      return;
    }

Comments

seanb’s picture

Status: Active » Needs review
StatusFileSize
new545 bytes

Patch is attached.

pascalli’s picture

Hi seanB,

Reviewed patch on local and comment line is updated as expected.

Bye for now.

jelle_s’s picture

Status: Needs review » Reviewed & tested by the community

Simple & straightforward. Assuming patch will be green (should be since there are no actual code changes)

oenie’s picture

Issue tags: -#amsterdam2014 +Amsterdam2014

fixing the amsterdam sprint tag to amsterdam2014

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed 4fc159c and pushed to 8.0.x. Thanks!

  • alexpott committed 4fc159c on 8.0.x
    Issue #2349839 by seanB: Fixed Code comment change for delete() in...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.