On the configuration page for the "Responsive Image Mapping" (admin/config/media/responsive-image-mapping) the mappings are not listed when using sqlite.
I think the problem lies within the listAll() function of the DatabaseStorage.php which is using ->query() instead of ->select() and therefore the mapConditionOperator() is not applied.

CommentFileSizeAuthor
#7 responsive_image_mappings-mappings-are-not-listed-with-sqlite-2349789-7.patch1.32 KBmgoedecke
#6 responsive_image_mappings-responsive-image-settings-are-not-listed-with-sqlite-2349789-6.patch1.32 KBmgoedecke
#1 responsive_image_mappings-responsive-image-settings-are-not-listed-with-sqlite-2349789-1.patch1.08 KBmgoedecke

Comments

mgoedecke’s picture

mgoedecke commented
StatusFileSize
new responsive_image_mappings-responsive-image-settings-are-not-listed-with-sqlite-2349789-1.patch1.08 KB

added patch

mgoedecke’s picture

mgoedecke commented
Status: Active » Needs review
mgoedecke’s picture

mgoedecke commented
Issue tags: -#amsterdam2014 +Amsterdam2014
mgoedecke’s picture

mgoedecke commented
Version: 8.0.0-beta1 » 8.0.x-dev

Status: Needs review » Needs work

The last submitted patch, 1: responsive_image_mappings-responsive-image-settings-are-not-listed-with-sqlite-2349789-1.patch, failed testing.

mgoedecke’s picture

mgoedecke commented
StatusFileSize
new responsive_image_mappings-responsive-image-settings-are-not-listed-with-sqlite-2349789-6.patch1.32 KB
mgoedecke’s picture

mgoedecke commented
StatusFileSize
new responsive_image_mappings-mappings-are-not-listed-with-sqlite-2349789-7.patch1.32 KB
dcrocks’s picture

dcrocks commented

This was reported previously in #2267563: Uncaught SQLite failure breaks responsive images, and had been fixed by #2318191: [meta] Database tests fail on SQLite, which is currently waiting re-roll. The latter has the same fix as yours butI would be happy to get either in. Testing your patch soon.

dcrocks’s picture

dcrocks commented
Status: Needs work » Needs review

Built new clone of D8.0, applied patch successfully, solved problem.

dcrocks’s picture

dcrocks commented
Status: Needs review » Reviewed & tested by the community

This works.

mgoedecke’s picture

mgoedecke commented

Ah ok - didn't find the other issue when i searched the issue queue.
Thanks for testing!

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 7cb8425 and pushed to 8.0.x. Thanks!

  • alexpott committed 7cb8425 on 8.0.x 
    Issue #2349789 by markus_g: Fixed Responsive Image Mappings are not...
mgoedecke’s picture

mgoedecke commented

Glad to help :-)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.