(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/search/templates/search-result.html.twig

Files: 
CommentFileSizeAuthor
#1 copy_search_templates-2349731-1.patch3.74 KBlauriii
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,471 pass(es). View

Comments

lauriii’s picture

Status: Active » Needs review
FileSize
3.74 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,471 pass(es). View
derheap’s picture

Issue tags: +cssbanana

Tagging cssbanana, as there is one css rule. But it is not used in this template.

(Just tried to upload the same patch – )

mortendk’s picture

Issue tags: +drupalhagen
runand’s picture

Assigned: Unassigned » runand
runand’s picture

Assigned: runand » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good.

davidhernandez’s picture

Status: Reviewed & tested by the community » Needs review

I'm universally setting all the phase 2 issues back to needs review, because we're missing some things. Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

mortendk’s picture

Status: Needs review » Reviewed & tested by the community

no js conflicts here

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

The only css class used is search-snippet-info and it is in bartik so all good here.

Committed 7e23406 and pushed to 8.0.x. Thanks!

This normal task was committed due the fact the banana consensus received per approval wrt to #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?

  • alexpott committed 7e23406 on 8.0.x
    Issue #2349731 by lauriii | davidhernandez: Copy search templates to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.