Copy image templates to Classy

moved the classes out of core + all template files copied over
Discussion of the classes - should be done as a follow up, so bikesheedding wont stop classy ;)

go bot go

+++ b/core/modules/image/templates/image-style-preview.html.twig
@@ -30,28 +30,28 @@
-      <div class="preview-image original-image" style="width: {{ preview.original.width }}px; height: {{ preview.original.height }}px;">
...
-      <div class="height" style="height: {{ preview.original.height }}px"><span>{{ original.height }}px</span></div>
-      <div class="width" style="width: {{ preview.original.width }}px"><span>{{ original.width }}px</span></div>
...
-      <div class="height" style="height: {{ preview.derivative.height }}px"><span>{{ derivative.height }}px</span></div>
-      <div class="width" style="width: {{ preview.derivative.width }}px"><span>{{ derivative.width }}px</span></div>

Are we really gonna remove styles from divs also? I thought classy is only about classes

The style attributes have to stay: they are necessary for the preview.

yup they are nessesary and thats why they are in classy - but not in the core.

I think derheap has a good point. These are the templates to generate previews of how image styles will look, right? That still has to work in themes that are using Core instead of Classy without every theme manually re-implementing that.

Although now that I'm thinking about it, an image style preview would be showing up in Seven, which is based on Classy, so this is maybe fine.

I dont think we should break functionality with classy

ok well then lets have a follow up issue on this & get it moved over without removing the inline styles.

Unremoved style attributes

to prevent disucssion about if inline styles are preferable in a template i have removed that from the patch, we can do that as a followup instead .

Could you provide interdiff?

Do we want to remove these empty divs and spans in the module template files?

We should do that as followup's lets get the templates into classy first, then we can clean up core even more if theres a need for that

I took some screenshots before and after. It looks like the image style preview functionality is broken in core or is it just me?

@david - didnt we end up in never ending bikesheds when we tried to do tomuch ?
keeping those things to followups, makes it easier for us to move stuff into classy & not beeing borked down.
Im pretty sure we did that on other issues before, but if its not gonna be suddenly blockers, then yes for all sake lets clean as much as possible :)

Ok thanks for the replies. I can confirm that the image style styling is broken in HEAD so we need to open a new issue], not fix it here.

• If there are classes that are required for basic functionality, discuss whether they should be kept.
• If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

This bit from the IS does not seem to have been done.

I have greped core for the classes that we are removing from image module templates, which are:

image-style-preview
preview
clearfix
preview-image-wrapper
preview-image
original-image
modified-image
height
width
image-preview
image-widget-data

There are no JS files in core that make use of any of these css classes that I could find.

As far as CSS goes, the ones I found are all in the module's CSS files: image.admin.css and image.theme.css. Please note that I ignored clearfix class because this is just a helper class.

On image.admin.css:
These are used (moved to classy in the patch)

• .image-style-preview
• .preview-image-wrapper
• .preview-image
• .width (!!)
• .height (!!)

On image.theme.css:
These are used:

• .image-preview
• .image-widget-data

These are NOT used anywhere (should be safe to remove)

• .preview
• .original-image
• .modified-image

ill set this back to rtbc - we are not cleaning out css nor are we yet moving css over.
Anyways templates are ready to be moved, css have been discussed & we have an overview :)

Templates changes are not blocked during beta. Committed 16d3e1c and pushed to 8.0.x. Thanks!