(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/file/templates/file-link.html.twig
core/modules/file/templates/file-managed-file.html.twig
core/modules/file/templates/file-upload-help.html.twig
core/modules/file/templates/file-widget-multiple.html.twig
core/modules/file/templates/file-widget.html.twig

Files: 
CommentFileSizeAuthor
#5 copy_file_templates_to-2349675-5.patch2.99 KBmortendk
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,472 pass(es). View
#5 interdiff-classy-file-2-5.patch4.54 KBmortendk
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch interdiff-classy-file-2-5.patch. Unable to apply patch. See the log in the details link for more information. View
#2 file-to-classy-2349675-2.patch3.06 KBemma.maria
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,912 pass(es). View
#1 class-file.diff2.92 KBmortendk
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,769 pass(es). View

Comments

mortendk’s picture

Assigned: Unassigned » mortendk
Status: Active » Needs review
FileSize
2.92 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,769 pass(es). View

moved the classes out of core
Discussion of the classes - should be done as a follow up, so bikesheedding wont stop classy ;)

emma.maria’s picture

FileSize
3.06 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 78,912 pass(es). View

In the last patch the template files in Classy were not added to a 'templates' folder in theme folder. I have moved the files over :)

emma.maria’s picture

Assigned: mortendk » Unassigned
davidhernandez’s picture

Status: Needs review » Needs work

The templates should go into the root of the templates folder, not a subfolder.

mortendk’s picture

Issue tags: +cssbanana
FileSize
4.54 KB
FAILED: [[SimpleTest]]: [PHP 5.4 MySQL] Unable to apply patch interdiff-classy-file-2-5.patch. Unable to apply patch. See the log in the details link for more information. View
2.99 KB
PASSED: [[SimpleTest]]: [PHP 5.4 MySQL] 79,472 pass(es). View

moved templates to /template

mortendk’s picture

Status: Needs work » Needs review

go bot go

The last submitted patch, 5: interdiff-classy-file-2-5.patch, failed testing.

mortendk’s picture

Issue tags: +drupalhagen
Xen’s picture

Assigned: Unassigned » Xen
Xen’s picture

Assigned: Xen » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good. All the templates are properly picked up.

davidhernandez’s picture

Status: Reviewed & tested by the community » Needs review

I'm universally setting all the phase 2 issues back to needs review, because we're missing some things. Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

Xen’s picture

Status: Needs review » Reviewed & tested by the community

There is no classes in the templates in this patch.

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Committed c71025a and pushed to 8.0.x. Thanks!

This normal task was committed due the fact the banana consensus received per approval wrt to #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?

  • alexpott committed c71025a on 8.0.x
    Issue #2349675 by mortendk, emma.maria | davidhernandez: Copy file...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.