Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
3 Oct 2014 at 12:21 UTC
Updated:
10 Nov 2014 at 11:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
mortendk commentedmoved the classes out of core
Discussion of the classes - should be done as a follow up, so bikesheedding wont stop classy ;)
Comment #2
emma.mariaIn the last patch the template files in Classy were not added to a 'templates' folder in theme folder. I have moved the files over :)
Comment #3
emma.mariaComment #4
davidhernandezThe templates should go into the root of the templates folder, not a subfolder.
Comment #5
mortendk commentedmoved templates to /template
Comment #6
mortendk commentedgo bot go
Comment #8
mortendk commentedComment #9
xen commentedComment #10
xen commentedLooks good. All the templates are properly picked up.
Comment #11
davidhernandezI'm universally setting all the phase 2 issues back to needs review, because we're missing some things. Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.
Comment #12
xen commentedThere is no classes in the templates in this patch.
Comment #13
alexpottCommitted c71025a and pushed to 8.0.x. Thanks!
This normal task was committed due the fact the banana consensus received per approval wrt to #2350615: [policy, no patch] What changes can be accepted during the Drupal 8 beta phase?