(First, verify that the preprocess changes have been made. #2322163: [meta] Consensus Banana Phase 1, move CSS classes from preprocess to twig templates.)

  1. Copy the Twig templates from the core module's templates directory to Classy's templates directory. Include all templates, even ones without classes.
  2. Remove all classes from the core module's template. Remove all classes added with addClass and ones that are hard-coded in the template.
  • If there are classes that are required for basic functionality, discuss whether they should be kept.
  • If there is CSS from the module, or anywhere else, referring to the class, discuss removing it or moving it to Bartik&Seven. Do not move the CSS to Classy.

Twig Templates to Copy

core/modules/comment/templates/comment.html.twig
core/modules/comment/templates/field--comment.html.twig

CommentFileSizeAuthor
#12 copy_commment_templates_2349659-11.patch9.54 KBmaninders
#8 copy_comment_templates-2349659-8.patch1.59 KBlauriii
#1 classy-comment.diff3.02 KBmortendk

Comments

mortendk’s picture

mortendk commented
Assigned: Unassigned » mortendk
Status: Active » Needs review
StatusFileSize
new classy-comment.diff3.02 KB

moved the classes out of core
Discussion of the classes - should be done as a follow up, so bikesheedding wont stop classy ;)

Status: Needs review » Needs work

The last submitted patch, 1: classy-comment.diff, failed testing.

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented
Status: Needs work » Postponed

The comment preprocess changes aren't in yet. #2329783: Move comment classes from preprocess to templates

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented

Please double-check if any removed classes are being used in javascript. It is best to test the affected template using Stark to make sure nothing is broken.

emma.maria’s picture

emma.maria
she/her
commented
Assigned: mortendk » Unassigned
Status: Postponed » Needs work

Status: Needs work » Needs review

lauriii queued 1: classy-comment.diff for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1: classy-comment.diff, failed testing.

lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs work » Needs review
StatusFileSize
new copy_comment_templates-2349659-8.patch1.59 KB
lauriii’s picture

lauriii
he/him
Primary language Finnish
Location Finland
commented
Status: Needs review » Postponed

This is still postponed by #2217731: Move field classes out of preprocess and into templates

davidhernandez’s picture

davidhernandez
Primary language English
Location USA
commented
Status: Postponed » Needs work

The field issue has been committed.

maninders’s picture

maninders commented
Assigned: Unassigned » maninders
maninders’s picture

maninders commented
StatusFileSize
new copy_commment_templates_2349659-11.patch9.54 KB

Done with the changes, 2349659-11.

maninders’s picture

maninders commented
Status: Needs work » Needs review
lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Reviewed & tested by the community

I tested the patch in Stark and nothing looked broken. I also compared the markup Stark markup in HEAD and the Classy markup with the patch to make sure they matched. They do.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Template change is not frozen in beta. Committed c0b45ec and pushed to 8.0.x. Thanks!

  • alexpott committed c0b45ec on 
    Issue #2349659 by Maninder, lauriii, mortendk: Copy comment templates to...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

maninders’s picture

maninders commented
Assigned: maninders » Unassigned
maninders’s picture

maninders commented