In Bartik, there is a border around region header which looks odd to me. Do we really need this?

Border around region header

Proposed:

Proposed solution

CommentFileSizeAuthor
#3 2349637.png38.8 KBskippednote
#2 remove_border_from-2349637-2.patch365 bytesmalcomio
Screen Shot 2014-10-03 at 13.38.12.png21.37 KBnathanlawsn
Screen Shot 2014-10-03 at 13.25.49.png21.59 KBnathanlawsn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

nathanlawsn’s picture

nathanlawsn CreditAttribution: nathanlawsn commented
FileSize
remove-border-from-region-header-in-bartik-2349637-1.patch365 bytes

Patch for proposed.

malcomio’s picture

malcomio CreditAttribution: malcomio commented
Assigned: Unassigned » malcomio
Status: Active » Needs review
FileSize
remove_border_from-2349637-2.patch365 bytes

Yes, I agree - here's a patch.

skippednote’s picture

skippednote CreditAttribution: skippednote commented
FileSize
2349637.png38.8 KB

Patch #2 looks good.

skippednote’s picture

skippednote CreditAttribution: skippednote commented
Status: Needs review » Reviewed & tested by the community
nathanlawsn’s picture

nathanlawsn CreditAttribution: nathanlawsn commented
Assigned: malcomio » Unassigned
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Well that definitely looks nicer. :)

Committed and pushed to 8.0.x. Thanks!

  • webchick committed a9e5c2f on 8.0.x 
    Issue #2349637 by malcomio | nathanlawson91: Remove border from region...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.