Problem/Motivation

CckFieldValues fails to migrate the alt and title properties from imagefields. Imagefield does not provide a new field type, it alter the existing file fields. Imagefield stores alt and title serialized in the data column.

Proposed resolution

Handle alt and title similar to list and description because is stored in {field_name}.data.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 2346415-6.patch3.2 KBsvendecabooter
#4 migrate-imagefields-2346415-3.patch1.45 KBwebflo
#2 migrate-imagefields-2346415-2.patch729 byteswebflo
#1 migrate-imagefields-2346415.patch1.74 KBwebflo

Comments

webflo’s picture

webflo commented
Status: Active » Needs work
Issue tags: +sprint, +Needs tests
StatusFileSize
new migrate-imagefields-2346415.patch1.74 KB
webflo’s picture

webflo commented
StatusFileSize
new migrate-imagefields-2346415-2.patch729 bytes

Enable alt and title attribute on image fields.

webflo’s picture

webflo commented
Status: Needs work » Needs review
webflo’s picture

webflo commented
StatusFileSize
new migrate-imagefields-2346415-3.patch1.45 KB

Lets use a real imagefield in the test. I copied the settings from my Drupal 6 installation.

Status: Needs review » Needs work

The last submitted patch, 4: migrate-imagefields-2346415-3.patch, failed testing.

svendecabooter’s picture

svendecabooter
he/him
Primary language Dutch
Location Gent
commented
Category: Bug report » Task
Status: Needs work » Needs review
StatusFileSize
new 2346415-6.patch3.2 KB

It seems the actual code (migrate-imagefields-2346415.patch) and the test (migrate-imagefields-2346415-3.patch) are added as 2 separate patches in this issue?

When I try to test migrate-imagefields-2346415.patch, I get the following error:

Migration failed with source plugin exception: SQLSTATE[42S22]: Column not found: 1054 Unknown column 'f.field_image_alt' in 'field list': SELECT f.field_image_fid AS field_image, f.field_image_data AS             [error]
field_image_data, f.field_image_alt AS field_image_alt, f.field_image_title AS field_image_title
FROM
{content_type_story} f
WHERE  (vid = :db_condition_placeholder_0) ; Array
(
    [:db_condition_placeholder_0] => 1
)

In attachment a patch that:
* Fixes this SQL error
* Combines the code + tests into 1 patch

However I still get an error upon testing this (as described in #2346039: Add missing migrations to MigrateDrupal6Test and fix the result), but it might be unrelated, so already adding the patch... Will have to test further once I get that issue out of the way.

Status: Needs review » Needs work

The last submitted patch, 6: 2346415-6.patch, failed testing.

quietone’s picture

quietone commented
Status: Needs work » Closed (duplicate)
Related issues: +#2604484: Migrate Drupal 7 image and file fields

Closing as a duplicate. This is being handled in #2604484: Migrate Drupal 7 image and file fields.