Update taxonomy tests to use specific create function when type is known

I'll work on this

Changed entity_create from all tests.

this look ok for me, but I don't understand why do we want to use the static functions for create here if for load (#2322509) we are trying to inject the entity storage and to use the entity storage function instead.

I think we should try to use the injected entity storage where is available and instead of Vocabulary::create write something like: $vocabulary_storage->create($values);

Changed static create.

Reroll for the patch from comment #8

needs beta evaluation

Rerolled

Rerolled

setting to needs review status so that the testbot runs on it.

restoring tags accidentally removed in #14

@lhangea Thank you for fixing some of those fails.
Since the patch before yours applied to head, you can make an interdiff.
This will help people learn how you fixed the fails, and also make it more likely someone will review the patch.

For instructions on creating an interdiff, see https://drupal.org/documentation/git/interdiff

It also really helps to describe in words why you made the changes you did.
(for example I think you fixed some coding standards stuff along with test fail fixes)

I uploaded a new patch which should be ok now and the interdiff (vs #15).

The changes can be seen pretty clear from the interdiff but basically there are small coding standard fixes, variable name changes and in some places I replaced the old static functions with methods of the injected objects.

+++ b/core/modules/taxonomy/src/Tests/LegacyTest.php
@@ -26,16 +26,19 @@ class LegacyTest extends TaxonomyTestBase {
+    $vocabulary_storage = $this->container->get('entity.manager')->getStorage('taxonomy_vocabulary');
+    $field_config_storage = $this->container->get('entity.manager')->getStorage('field_config');
+    $field_storage_config_storage = $this->container->get('entity.manager')->getStorage('field_storage_config');
 

adding those lines, essencially removed the newline under setup.

I was also super tempted to try

    /** @var \Drupal\taxonomy\VocabularyInterface $vocabulary_storage */
    $vocabulary_storage = $this->container->get('entity.manager')->getStorage('taxonomy_vocabulary');
    /** @var \Drupal\field\FieldConfigInterface $field_config_storage */
    $field_config_storage = $this->container->get('entity.manager')->getStorage('field_config');
    /** @var \Drupal\field\FieldStorageConfigInterface $field_storage_config_storage */
    $field_storage_config_storage = $this->container->get('entity.manager')->getStorage('field_storage_config');

Why not type, so that ->create() is known to be a method?

on second thought, I think this is fine.

with patch applied,
ag entity_create core/modules/taxonomy
does not show any usages of entity_create in taxonomy tests, so this got them all.

We changed direction in #7 but the IS has not been updated. I'm not convinced by Node::create() in a test is worse that getting the storage from the entity manager - but whatever as this hardly matters.

This is a duplicate of the various taxonomy-related child issues here: #2490966: [Meta] Replace deprecated usage of entity_create with a direct call to the entity type class

Thanks, folks!