CommentFileSizeAuthor
and_or.patch3.12 KBolli

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Issue tags: +VDC

I disagree, + means "and" to me.

Also this is a preexisting pattern from Views for multiple arguments.

olli’s picture

olli commented

In views, there is a checkbox "Allow multiple values" with description "If selected, users can enter multiple values in the form of 1+2+3 (for OR) or 1,2,3 (for AND).".

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Oh. Um. Well yeah I guess you're right :D

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

Oh wow, indeed, see https://api.drupal.org/api/drupal/modules%21taxonomy%21taxonomy.module/f...

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed e4242c4 and pushed to 8.0.x. Thanks!

olli’s picture

olli commented

CR https://www.drupal.org/node/1851490 needs an update?

  • alexpott committed e4242c4 on 8.0.x 
    Issue #2346105 by olli: Fixed Use 1+2+3 for OR, 1,2,3 for AND.
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented

Yep @olli you're right - can you update it? And add this issue to it.

olli’s picture

olli commented

https://www.drupal.org/node/1851490/revisions/view/2896897/7672129

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.