I'm not sure if this was a decision that was made at some stage but when createing a node if you check the "Provide a menu link" checkbox then the node/entity title is no longer copied to the "Menu link title" field, now is the field required so you are able to save the node without a menu being actually created.

CommentFileSizeAuthor
#6 menu_ui-2346001-6-patched.png41.35 KBmurrayw
#6 menu_ui-2346001-6-bug.png40.92 KBmurrayw
#3 menu_ui-2346001-3.patch1.87 KBFredericoT

Comments

realityloop’s picture

realityloop commented
Issue summary: View changes
Related issues: +#1763002: Saving a node with an empty menu link title causes the menu link to silently not be created
realityloop’s picture

realityloop commented

There appears to be javascript for this in /core/modules/menu_ui/menu_ui.js

FredericoT’s picture

FredericoT commented
StatusFileSize
new menu_ui-2346001-3.patch1.87 KB

Looks to me because the #attached attribute is incorrect and because of that menu_ui.js was not being loaded. And also a couple of selectors seem to be incorrect.

The following patch corrects the issue for me.

FredericoT’s picture

FredericoT commented
Status: Active » Needs review
dawehner’s picture

dawehner
Primary language German
commented 
+++ b/core/modules/menu_ui/menu_ui.module
@@ -319,7 +319,7 @@ function menu_ui_form_node_form_alter(&$form, FormStateInterface $form_state) {
-      'library' => array('menu/drupal.menu'),
+      'library' => array('menu_ui/drupal.menu_ui'),

Oh wow, can we add validation on library level, just curious.

murrayw’s picture

murrayw commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new menu_ui-2346001-6-bug.png40.92 KB
new menu_ui-2346001-6-patched.png41.35 KB

I have manually tested the patch #3 and it works. The functionality is the same as in d7. I think that this is RTBC.

dawehner - I am not sure if it is correct to include validation in this way in the library. My gut feel is that it is OK in this case. Splitting that out into a new file would make things more complex.

I have attached screenshots showing the before and after.

realityloop’s picture

realityloop commented

Thanks for the screenshots @murrayw, if you are using dreditor (dreditor.org) it's handy to embed the images in your post :)

Before:

After:

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1c95b46 and pushed to 8.0.x. Thanks!

  • alexpott committed 1c95b46 on 8.0.x 
    Issue #2346001 by Frederico | realityloop: Fixed Menu link title not...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.