Obsoleted by #2271349: Node and Comment ops links should be display components (which can be disabled).

Beta phase evaluation

Reference: https://www.drupal.org/core/beta-changes
Unfrozen changes Unfrozen because it only removes obsolete code.
CommentFileSizeAuthor
#10 2345867-10.patch6.04 KBgábor hojtsy
#7 interdiff.txt618 bytesolli
#7 2345867-7.patch16.79 KBolli
#5 interdiff.txt15.02 KBolli
#5 2345867-5.patch16.19 KBolli
remove-node_row_node_view_preprocess_node.patch1.17 KBolli

Comments

jhedstrom queued remove-node_row_node_view_preprocess_node.patch for re-testing.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Issue summary: View changes
olli’s picture

olli commented

We still have the with links/without links option in node and comment wizards. I think we could remove those too.

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented

@olli do you want to reroll the patch to remove those?

olli’s picture

olli commented
Title: Remove node_row_node_view_preprocess_node() » Remove node_row_node_view_preprocess_node() and links option from ui, config and schema
Priority: Minor » Normal
StatusFileSize
new 2345867-5.patch16.19 KB
new interdiff.txt15.02 KB

Status: Needs review » Needs work

The last submitted patch, 5: 2345867-5.patch, failed testing.

olli’s picture

olli commented
Status: Needs work » Needs review
StatusFileSize
new 2345867-7.patch16.79 KB
new interdiff.txt618 bytes
olli’s picture

olli commented
Status: Needs review » Postponed

Let's fix #2381973: View wizard creates 'invalid' views out of the box, missing plugin_ids, insecure permissions first.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Postponed » Needs work

#2381973: View wizard creates 'invalid' views out of the box, missing plugin_ids, insecure permissions landed, so most of this patch landed. Some stuff still to be done.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Status: Needs work » Needs review
StatusFileSize
new 2345867-10.patch6.04 KB

Rerolled. I don't understand how the last hunk is related but I kept it in.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented
Title: Remove node_row_node_view_preprocess_node() and links option from ui, config and schema » Remove node_row_node_view_preprocess_node() and dead code in the comment views wizard
gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@jhedstrom: what do you think? :)

olli’s picture

olli commented

#10: The last hunk was needed to call node_row_node_view_preprocess_node() from node.views.inc, see #1793696: views_preprocess_node check for the wrong row_plugin.

gábor hojtsy’s picture

gábor hojtsy
he/him
Primary language Hungarian
Location Hungary
commented

@olli: makes sense, thanks! Anything else to do here? Looks like @jhedstrom could review :)

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Reviewed & tested by the community

I was at first unclear why the tests were changed, but looking closer, the removed comment code doesn't remove any assertions, it simply removes unused or irrelevent code for those tests.

I think #10 is RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed 0f4bceb on 8.0.x 
    Issue #2345867 by olli, Gábor Hojtsy: Remove...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.