Fix ThirdPartySettingsTrait property capitalization [#2345097]

Problem/Motivation

As discussed in #2224761-145: Add a generic way to add third party configuration on configuration entities and implement for field configuration and later, \Drupal\Core\Config\Entity\ThirdPartySettingsTrait::third_party_settings is not camelcased, as it should have been according our coding standards.

Proposed resolution

Camelcase the property.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Comment	File	Size	Author
#1	drupal_2345097_1.patch	2.11 KB	Xano
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 25 September 2014 at 20:08

File	Size
drupal_2345097_1.patch	2.11 KB

Comment #2

25 September 2014 at 21:04

Status:

Needs review

» Needs work

The last submitted patch, 1: drupal_2345097_1.patch, failed testing.

Comment #3

yched CreditAttribution: yched commented 25 September 2014 at 21:30

I don't understand this. As discussed in the issue, HEAD currently uses underscores for ConfigEnttity class members that live in yaml. So why would we change third_party_settings specifically ?

Comment #4

Xano

he/they

English

Southampton

CreditAttribution: Xano commented 4 October 2014 at 16:36

Because we keep adding more and more code to core that does not comply with our coding standards.

Comment #5

yched CreditAttribution: yched commented 4 October 2014 at 18:47

Status:

Needs work

» Closed (won't fix)

None of core config entities comply with our coding standards, so let's align ThirdPartySettingsTrait to camelcase when the rest is in camlcase too. Sorry, I really don't see why we would treat ThirdPartySettingsTrait differently than the rest of core.