Problem/Motivation

As discussed in #2224761-145: Add a generic way to add third party configuration on configuration entities and implement for field configuration and later, \Drupal\Core\Config\Entity\ThirdPartySettingsTrait::third_party_settings is not camelcased, as it should have been according our coding standards.

Proposed resolution

Camelcase the property.

Remaining tasks

None.

User interface changes

None.

API changes

None.

CommentFileSizeAuthor
#1 drupal_2345097_1.patch2.11 KBxano

Comments

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
StatusFileSize
new drupal_2345097_1.patch2.11 KB

Status: Needs review » Needs work

The last submitted patch, 1: drupal_2345097_1.patch, failed testing.

yched’s picture

yched commented

I don't understand this. As discussed in the issue, HEAD currently uses underscores for ConfigEnttity class members that live in yaml. So why would we change third_party_settings specifically ?

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Because we keep adding more and more code to core that does not comply with our coding standards.

yched’s picture

yched commented
Status: Needs work » Closed (won't fix)

None of core config entities comply with our coding standards, so let's align ThirdPartySettingsTrait to camelcase when the rest is in camlcase too. Sorry, I really don't see why we would treat ThirdPartySettingsTrait differently than the rest of core.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

@yched and I hugged at DrupalCon. We're good.

yched’s picture

yched commented

@Xano: it was a back-stab hug, I have a cold. Muhaha.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

I made sure our docs reflect this: https://www.drupal.org/node/608152/revisions/view/7493713/7732127