Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Problem/Motivation
ControllerBase has a convenience method for generating a RedirectResponse.
This would be useful for FormBase and others, which are already using UrlGeneratorTrait.
Proposed resolution
Move redirect() to UrlGeneratorTrait
Remaining tasks
User interface changes
API changes
Comment | File | Size | Author |
---|---|---|---|
#3 | interdiff.txt | 1.38 KB | tim.plunkett |
#3 | 2344491-url-redirect-3.patch | 7.66 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettI've converted the cases that already used $this->url(), leaving the url() calls for #2340251: Remove most remaining url() calls.
Comment #2
dawehnerI can haz tests?
Comment #3
tim.plunkettAsk and ye shall receive.
Comment #4
znerol CreditAttribution: znerol commentedsee #2282161-10: Split off link/url generation trait
Comment #5
jibranLooks great.
Comment #6
znerol CreditAttribution: znerol commentedFrom the original issue I linked in #4.
Did something change in the meantime such that it is now justifiable to add
redirect()
to the trait?Comment #7
tim.plunkettWe still need them in Forms.
Comment #8
alexpottCommitted 4014b74 and pushed to 8.0.x. Thanks!
Yep forms need this.