Multiple RTL CSS issues have been fixed in the patch. Also, I have included an RTL version of the favstar icon used in the shortcut module.

1. Bad "Edit Shortcuts" position in toolbar (should be on opposite side):

LTR:




RTL - before:


RTL - after:


2. Wrong margins and image for add/remove shortcut links
The margins for the add/remove shortcut link texts didn't have RTL equivalents. Although, the margins are rather small, so they aren't very visible in the screenshots.
The favstar icon's +/x marks should also face away from the shortcut title, so I added an RTL equivalent for the icon.

LTR:


RTL - before:


RTL - after:


Here is also the favstar icons:

LTR:


RTL (new):

CommentFileSizeAuthor
#11 fix-shortcut-module-rtl-11.patch11.23 KBherom
#11 interdiff-2343715-0-11.txt2.26 KBherom
fix-shortcut-module-rtl.patch13.48 KBherom
favstar-rtl.png1.99 KBherom
favstar.png1.8 KBherom
shortcut-favstar-rtl-fixed.png4.4 KBherom
shortcut-favstar-rtl-before.png4.37 KBherom
shortcut-favstar-ltr.png4.68 KBherom
shortcut-edit-link-rtl-fixed.png7.05 KBherom
shortcut-edit-link-rtl-before.png7.11 KBherom
shortcut-edit-link-ltr.png7.15 KBherom

Comments

herom’s picture

herom commented
Issue summary: View changes
Karmen’s picture

Karmen commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +Amsterdam2014

I review this, and this patch works for me perfectly.

Pretty work :)

lewisnyman’s picture

lewisnyman
he/him
commented

Thanks for fixing this! RTBC++

Status: Reviewed & tested by the community » Needs work

The last submitted patch, fix-shortcut-module-rtl.patch, failed testing.

Status: Needs work » Needs review

herom queued fix-shortcut-module-rtl.patch for re-testing.

herom’s picture

herom commented
Status: Needs review » Reviewed & tested by the community

HEAD was broken. back to rtbc.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, fix-shortcut-module-rtl.patch, failed testing.

Status: Needs work » Needs review

LewisNyman queued fix-shortcut-module-rtl.patch for re-testing.

herom’s picture

herom commented
Status: Needs review » Reviewed & tested by the community

Overloaded testbot! Back to rtbc.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/shortcut/css/shortcut.theme.css
--- /dev/null
+++ b/core/modules/shortcut/images/favstar-rtl.png

I don' think we need the png file since we're only using the svg.

herom’s picture

herom commented
Status: Needs work » Needs review
StatusFileSize
new interdiff-2343715-0-11.txt2.26 KB
new fix-shortcut-module-rtl-11.patch11.23 KB

removed the png file.

lewisnyman’s picture

lewisnyman
he/him
commented
Status: Needs review » Reviewed & tested by the community

I doubled check this patch again. Looks great. Thank you.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed ec054f3 and pushed to 8.0.x. Thanks!

  • alexpott committed ec054f3 on 8.0.x 
    Issue #2343715 by herom: Fixed RTL issues in shortcut module.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.