Suggested commit message:

Issue #2343631 by chx, Wim Leers: Improve AccessResultInterface andIf()/orIf() docs.

Problem/Motivation

effulgentsia pointed out in #2340507-48: Make the new AccessResult API and implementation even better that objects implementing AccessResultInterface ARE NOT implementing Kleene logic, only a subset of it.

Proposed resolution

Remove this statement from the interface doxygen, add relevant doxygen and truth tables to the methods. I made a mistake by not including truth tables in the first place.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 2343631_4.patch1.56 KBchx
klenee3vl.patch1.74 KBchx

Comments

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Title: Improve AccessResultInterface andIf/orIf doxygen » Improve AccessResultInterface andIf()/orIf() docs
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
Issue tags: +DX (Developer Experience)

The truth tables in this patch are the ones I wrote at #2340507-44: Make the new AccessResult API and implementation even better. They're correct.

effulgentsia’s picture

effulgentsia commented

Thanks! +1.

chx’s picture

chx commented
Issue summary: View changes

Yes, credit where credit is due, sorry for not including in the first place.

chx’s picture

chx commented
StatusFileSize
new 2343631_4.patch1.56 KB

On discussion with jhodgdon I removed actually the Kleene weak 3vl reference -- it buys us little and with forbidden being the intermediate value it just melts your brain, really. It's good we know it is one and we didn't invent something out of blue but the added value to link to a wikipedia section which says practically nothing beyond the truth tables is not helpful. You'd need something like http://boa.unimib.it/bitstream/10281/46285/1/ins250-web.pdf for a better understanding of 3VL and that's way too much.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 8.0.x.

  • jhodgdon committed c303b2c on 8.0.x 
    Issue #2343631 by chx, Wim Leers: Improve AccessResultInterface andIf()/...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.