Follow-up to #2312093-58: Rename FieldInstanceConfig to FieldConfig

Also #61

CommentFileSizeAuthor
#12 2343483-doc_adjustments-12.patch1.12 KByched
#9 2343483-9.patch1.85 KBandypost
#7 2343483-7.patch2.49 KBandypost
#7 interdiff.txt625 bytesandypost
#3 2343483-1.patch1.88 KBandypost
2312093-wtf.patch744 bytesandypost
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Title: Cleanup aftter FieldConfig » Cleanup after FieldConfig
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented

Can we also do https://www.drupal.org/node/2312093#comment-9164319 points 1 - 2 as well. Thanks.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
2343483-1.patch1.88 KB

fix all (3) pointed

Berdir queued 3: 2343483-1.patch for re-testing.

andyceo queued 3: 2343483-1.patch for re-testing.

yched’s picture

yched CreditAttribution: yched commented 
+++ b/core/lib/Drupal/Core/Field/FieldConfigBase.php
@@ -32,7 +32,7 @@
-   * The name of the field attached to the bundle by this field.
+   * The machine name of the field attached to the bundle.

Can we use the same text than for FieldStorageConfig::$field_name ?

  /**
   * The field name.
   *
   * This is the name of the property under which the field values are placed in
   * an entity: $entity->{$field_name}. The maximum length is
   * Field:NAME_MAX_LENGTH.
   *
   * Example: body, field_main_image.
   *
   * @var string
   */
andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
interdiff.txt625 bytes
2343483-7.patch2.49 KB

fixed #6

yched’s picture

yched CreditAttribution: yched commented

@andypost: no, I meant the other way around: do not touch FieldStorageConfig, and put in FieldConfigBase the same text that appears in FieldStorageConfig.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented
FileSize
2343483-9.patch1.85 KB

done, here's one

yched’s picture

yched CreditAttribution: yched commented
Status: Needs review » Reviewed & tested by the community

Sorry for letting this slide. #9 is good to go.
Thanks @andypost !

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Category: Task » Bug report
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs tests, +Needs issue summary update

This looks like we have no test coverage then.

yched’s picture

yched CreditAttribution: yched commented
Status: Needs work » Reviewed & tested by the community
FileSize
2343483-doc_adjustments-12.patch1.12 KB

The 

- $class::fieldSettingsFromConfigData($record['settings']);
+ $class::fieldSettingsToConfigData($record['settings']);

part got fixed (with the missing tests) in #2437785: FieldConfigStorageBase::mapToStorageRecord() calls the wrong field type method

This leaves just the doc fixes here. Reroll, and back to RTBC.

yched’s picture

yched CreditAttribution: yched commented
Title: Cleanup after FieldConfig » Doc cleanup after FieldConfig
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

Documentation is not frozen in beta. Committed 374f838 and pushed to 8.0.x. Thanks!

  • alexpott committed 374f838 on 8.0.x 
    Issue #2343483 by andypost, yched: Doc cleanup after FieldConfig

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.