Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
field system
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
23 Sep 2014 at 14:28 UTC
Updated:
14 Mar 2015 at 16:14 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
alexpottComment #2
alexpottCan we also do https://www.drupal.org/node/2312093#comment-9164319 points 1 - 2 as well. Thanks.
Comment #3
andypostfix all (3) pointed
Comment #6
yched commentedCan we use the same text than for FieldStorageConfig::$field_name ?
Comment #7
andypostfixed #6
Comment #8
yched commented@andypost: no, I meant the other way around: do not touch FieldStorageConfig, and put in FieldConfigBase the same text that appears in FieldStorageConfig.
Comment #9
andypostdone, here's one
Comment #10
yched commentedSorry for letting this slide. #9 is good to go.
Thanks @andypost !
Comment #11
alexpottThis looks like we have no test coverage then.
Comment #12
yched commentedThe
part got fixed (with the missing tests) in #2437785: FieldConfigStorageBase::mapToStorageRecord() calls the wrong field type method
This leaves just the doc fixes here. Reroll, and back to RTBC.
Comment #13
yched commentedComment #14
alexpottDocumentation is not frozen in beta. Committed 374f838 and pushed to 8.0.x. Thanks!