There are a few RTL issues in the front page of Bartik.

Here are screenshots:

LTR



RTL - before



RTL - after

I have added extra context lines in the patch, so that the original LTR CSS rules are visible.

CommentFileSizeAuthor
#9 Selection_007.png55.29 KBrpayanm
#5 2343181-4-0preview.png41.14 KBvermario
#5 2343181-4-preview.png53.4 KBvermario
#4 fix-homepage-rtl-2343181-4.patch976 bytesherom
fix-homepage-rtl.patch2.51 KBherom
homepage-rtl-fixed.png42.4 KBherom
homepage-rtl-before-annotated.png52.61 KBherom
homepage-ltr.png42.99 KBherom

Comments

herom’s picture

herom commented
Issue summary: View changes

LewisNyman queued fix-homepage-rtl.patch for re-testing.

Status: Needs review » Needs work

The last submitted patch, fix-homepage-rtl.patch, failed testing.

herom’s picture

herom commented
Status: Needs work » Needs review
StatusFileSize
new fix-homepage-rtl-2343181-4.patch976 bytes

Rerolled. One case had went in from another issue.

vermario’s picture

vermario commented
StatusFileSize
new 2343181-4-preview.png53.4 KB
new 2343181-4-0preview.png41.14 KB

The patch applies correctly and the menu is displayed on the right:

however, at smaller screen sizes, the responsive version of the same element is still floated to the left:

This should also be fixed, I think?

vermario’s picture

vermario commented
Status: Needs review » Needs work
vermario’s picture

vermario commented
Status: Needs work » Reviewed & tested by the community

:) Sorry! Turns out that clearing caches is a good idea when reviewing CSS patches. Looks ok to me now :) :)

sqndr’s picture

sqndr commented
Status: Reviewed & tested by the community » Needs work
Issue tags: +Needs screenshots, +Novice

@vermario: Could you provide another mobile/responsive screenshot where the menu is displayed correctly? That would be awesome. Patch looks good. Thanks!

rpayanm’s picture

rpayanm
he/him
Primary language Spanish
commented
StatusFileSize
new Selection_007.png55.29 KB

Looks good...

RTL

herom’s picture

herom commented
Status: Needs work » Reviewed & tested by the community
Issue tags: -Needs screenshots, -Novice

Thanks @rpayanm.
The patch is reviewed and tested in #7 - #9, so marking RTBC.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

This issue is a normal bug fix, and doesn't include any disruptive changes, so it is allowed per https://www.drupal.org/core/beta-changes. Committed bbd92ba and pushed to 8.0.x. Thanks!

  • alexpott committed bbd92ba on 8.0.x 
    Issue #2343181 by herom, vermario, rpayanm: RTL issues on front page

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.