Problem/Motivation

logger.channel.default:
    class: Drupal\Core\Logger\LoggerChannel
    factory_method: get
    factory_service: logger.factory
    arguments: ['system']
  logger.channel.php:
    class: Drupal\Core\Logger\LoggerChannel
    factory_method: get
    factory_service: logger.factory
    arguments: ['php']
  logger.channel.image:
    class: Drupal\Core\Logger\LoggerChannel
    factory_method: get
    factory_service: logger.factory
    arguments: ['image']
  logger.channel.cron:
    class: Drupal\Core\Logger\LoggerChannel
    factory_method: get
    factory_service: logger.factory
    arguments: ['cron']
  logger.channel.form:
    class: Drupal\Core\Logger\LoggerChannel
    factory_method: get
    factory_service: logger.factory
    arguments: ['form']

Proposed resolution

  logger.channel.default:
    parent: logger.channel_base
    arguments: ['system']
  logger.channel.php:
    parent: logger.channel_base
    arguments: ['php']
  logger.channel.image:
    parent: logger.channel_base
    arguments: ['image']
  logger.channel.cron:
    parent: logger.channel_base
    arguments: ['cron']
  logger.channel.form:
    parent: logger.channel_base
    arguments: ['form']

Remaining tasks

review/commit

User interface changes

None

API changes

None

Comments

ParisLiakos’s picture

Status: Active » Needs review
StatusFileSize
new1.35 KB
dawehner’s picture

Awesome idea!
Note: there are also logger defined in aggregator, dblog, rest and syslog you might could update as well.

ParisLiakos’s picture

StatusFileSize
new1.13 KB
new1.35 KB

oooh indeed, totally forgot those, thanks!! not syslog though ;)

ParisLiakos’s picture

StatusFileSize
new2.49 KB

meh, wrong patch:) interdiff is correct

dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Cool, thank you!

The last submitted patch, 3: interdiff-2341701.patch, failed testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, 4: drupal-2341701-3.patch, failed testing.

ParisLiakos’s picture

Status: Needs work » Needs review
StatusFileSize
new385 bytes
new2.5 KB

thats embarassing :/

tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

This is great, thanks!

catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.0.x, thanks!

  • catch committed bc8ffe3 on 8.0.x
    Issue #2341701 by ParisLiakos: Provide an abstract logger.channel...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.