Problem/Motivation

When installing, the "Missing files folder" error message shows escaped(?) html instead of rendered html. See attached screenshot.

Proposed resolution

Make it not escaped?

CommentFileSizeAuthor
#4 Screen Shot 2014-09-20 at 2.03.01 AM.png259.74 KBxlin
#4 interdiff.2341607.4.txt2.15 KBxlin
#4 2341607.4.patch2.15 KBxlin
html-in-installer-error.png135.85 KByoroy

Comments

yoroy’s picture

yoroy commented
Issue tags: +Novice

Tag

xlin’s picture

xlin commented

Hi,

I encountered same issue when missing files directory. Can you point to me which file to look at to fix this issue?

Thanks.

yoroy’s picture

yoroy commented

What I usually do is just search core codebase for this text, that should get you to the right place. I'm not a coder though, so how to fix this, I don't know. Thanks for looking :)

xlin’s picture

xlin commented
Status: Active » Needs review
StatusFileSize
new 2341607.4.patch2.15 KB
new interdiff.2341607.4.txt2.15 KB
new Screen Shot 2014-09-20 at 2.03.01 AM.png259.74 KB

Thanks for the tip Yoroy.

This error occur due to chain of t() function.

yoroy’s picture

yoroy commented

Thanks for the patch. Can't test this with simplytest.me because there the files folder always exists so we'll need a manual review. Experienced coders could probably tell from just looking at the patch if the patch is correct, or somebody do a fresh install with the patch applied and see if the bug is corrected.

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Closed (duplicate)

Thanks for the report! I think this is already in progress at #2317281: Double escaping of install errors or should be incorporated there.